Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752227AbdHKAGT (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 20:06:19 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:17674 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752046AbdHKAGR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 20:06:17 -0400
To: Pan Bian <bianpan2016@163.com>
Cc: qla2xxx-upstream@qlogic.com,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: scsi: qla2xxx: use dma_mapping_error to check map errors
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <1502200531-15219-1-git-send-email-bianpan2016@163.com>
Date: Thu, 10 Aug 2017 20:06:02 -0400
In-Reply-To: <1502200531-15219-1-git-send-email-bianpan2016@163.com> (Pan
        Bian's message of "Tue, 8 Aug 2017 21:55:30 +0800")
Message-ID: <yq1h8xf2ck5.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 296
Lines: 12


Pan,

> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function qla26xx_dport_diagnostics(),
> its return value is checked against NULL, which could result in
> failures.

Applied to 4.14/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering