Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbdHKApy (ORCPT ); Thu, 10 Aug 2017 20:45:54 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35506 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdHKApw (ORCPT ); Thu, 10 Aug 2017 20:45:52 -0400 Date: Thu, 10 Aug 2017 17:45:49 -0700 From: Dmitry Torokhov To: Pan Bian Cc: Greg Kroah-Hartman , Guenter Roeck , Wei Yongjun , Thierry Escande , Christophe JAILLET , Wei-Ning Huang , linux-kernel@vger.kernel.org Subject: Re: [V3] firmware: vpd: use memunmap instead of iounmap Message-ID: <20170811004549.GA13947@dtor-ws> References: <1502406793-26329-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502406793-26329-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 65 On Fri, Aug 11, 2017 at 07:13:13AM +0800, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() should be > used. > > Signed-off-by: Pan Bian Reviewed-by: Dmitry Torokhov > --- > V2: change error label err_iounmap to err_memunmap > V3: add changes from V1 to V2 > --- > drivers/firmware/google/vpd.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c > index 7894572..35e553b 100644 > --- a/drivers/firmware/google/vpd.c > +++ b/drivers/firmware/google/vpd.c > @@ -202,7 +202,7 @@ static int vpd_section_init(const char *name, struct vpd_section *sec, > sec->raw_name = kasprintf(GFP_KERNEL, "%s_raw", name); > if (!sec->raw_name) { > err = -ENOMEM; > - goto err_iounmap; > + goto err_memunmap; > } > > sysfs_bin_attr_init(&sec->bin_attr); > @@ -233,8 +233,8 @@ static int vpd_section_init(const char *name, struct vpd_section *sec, > sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr); > err_free_raw_name: > kfree(sec->raw_name); > -err_iounmap: > - iounmap(sec->baseaddr); > +err_memunmap: > + memunmap(sec->baseaddr); > return err; > } > > @@ -245,7 +245,7 @@ static int vpd_section_destroy(struct vpd_section *sec) > kobject_put(sec->kobj); > sysfs_remove_bin_file(vpd_kobj, &sec->bin_attr); > kfree(sec->raw_name); > - iounmap(sec->baseaddr); > + memunmap(sec->baseaddr); > } > > return 0; > @@ -262,7 +262,7 @@ static int vpd_sections_init(phys_addr_t physaddr) > return -ENOMEM; > > memcpy_fromio(&header, temp, sizeof(struct vpd_cbmem)); > - iounmap(temp); > + memunmap(temp); > > if (header.magic != VPD_CBMEM_MAGIC) > return -ENODEV; > -- > 1.9.1 > > -- Dmitry