Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdHKBn6 (ORCPT ); Thu, 10 Aug 2017 21:43:58 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:48640 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbdHKBn4 (ORCPT ); Thu, 10 Aug 2017 21:43:56 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: wmc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <83b3af090bb3b65ea515d0642a8939d6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk To: Rob Herring Cc: heiko@sntech.de, kishon@ti.com, mark.rutland@arm.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, william.wu@rock-chips.com, daniel.meng@rock-chips.com, kever.yang@rock-chips.com, andy.yan@rock-chips.com, wmc@rock-chips.com References: <1501747753-6983-1-git-send-email-frank.wang@rock-chips.com> <1501747753-6983-3-git-send-email-frank.wang@rock-chips.com> <20170810170508.pwf35mud4ffnrzzd@rob-hp-laptop> From: Frank Wang Message-ID: <553ed6db-9d5a-d453-92f1-677bc63fdb5b@rock-chips.com> Date: Fri, 11 Aug 2017 09:43:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810170508.pwf35mud4ffnrzzd@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 47 Hi Rob, On 2017/8/11 1:05, Rob Herring wrote: > On Thu, Aug 03, 2017 at 04:09:10PM +0800, Frank Wang wrote: >> Add rockchip,usbgrf and rockchip,companion_grf_quirk to support >> the registers of usb-phy that are distributed in grf and usbgrf >> on some special Rockchip SoCs (e.g RV1108). >> >> Signed-off-by: Frank Wang >> --- >> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> index 84d59b0..ddf868a 100644 >> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> @@ -18,6 +18,10 @@ Optional properties: >> usb-phy output 480m and xin24m. >> Refer to clk/clock-bindings.txt for generic clock >> consumer properties. >> + - rockchip,usbgrf : phandle to the syscon managing the "usb general >> + register files". >> + - rockchip,companion_grf_quirk : when set driver will request >> + "rockchip,usbgrf" phandle as one companion-grf. > Why isn't presence of rockchip,usbgrf or being implied by an SoC > specific compatible string enough? > > In any case, use '-' rather than '_'. All right, thanks for your comments, I will fix it with matching SoC specific compatible string. BR. Frank >> >> Required nodes : a sub-node is required for each port the phy provides. >> The sub-node name is used to identify host or otg port, >> -- >> 2.0.0 >> >> > >