Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752124AbdHKBui (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 21:50:38 -0400
Received: from mail-wm0-f45.google.com ([74.125.82.45]:38231 "EHLO
        mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751691AbdHKBug (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 21:50:36 -0400
Date: Fri, 11 Aug 2017 09:50:21 +0800
From: Leo Yan <leo.yan@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Guodong Xu <guodong.xu@linaro.org>, xuwei5@hisilicon.com,
        robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com,
        will.deacon@arm.com, keescook@chromium.org, anton@enomsg.org,
        ccross@android.com, tony.luck@intel.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Kevin Wang <jean.wangtao@linaro.org>
Subject: Re: [PATCH v2 1/9] arm64: dts: hi3660: enable idle states
Message-ID: <20170811015020.GF3819@leoy-ThinkPad-T440>
References: <20170810022615.19204-1-guodong.xu@linaro.org>
 <20170810022615.19204-2-guodong.xu@linaro.org>
 <b3d8f55b-3d70-9b3a-a4c6-474a933a13a9@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b3d8f55b-3d70-9b3a-a4c6-474a933a13a9@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1254
Lines: 45

Hi Daniel,

On Thu, Aug 10, 2017 at 12:07:07PM +0200, Daniel Lezcano wrote:
> 
> Hi Guodong, Leo,
> 
> there are several typos in the patch description. I *humbly* propose an
> alternate description to make it a bit more English friendly.
> 
> """
> 
> There are two clusters on the Hi3660, the first one is Cortex-A53 based
> and the other one is Cortex-A73 based. These two clusters have different
> idle states.
> 
> Thanks to Daniel Lezcano's recent changes, the generic ARM cpuidle
> driver can now support several clusters with different idle states, thus
> supporting the big.Little architecture.
> 
> In addition to the WFI idle state which is the default shallowest state
> for all ARM cpus, the Hi3660 supports the following states:
> 
>  - CA53 CPUs:
> 	- CPU_SLEEP:       CPU power off state
> 	- CLUSTER_SLEEP_0: Cluster power off state
> 
>  - CA73 CPUs:
> 	- CPU_NAP:         CPU retention state
> 	- CPU_SLEEP:       CPU power off state
> 	- CLUSTER_SLEEP_1: Cluster power off state
> 
> This patch adds the idle states description for the Hi3660 to the device
> tree.
> 
> """
> 
> 
> Other than that.
> 
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Thanks a lot for proposing commit log, it's much better :)

Thanks,
Leo Yan