Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752401AbdHKCxO (ORCPT ); Thu, 10 Aug 2017 22:53:14 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:4487 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752169AbdHKCxM (ORCPT ); Thu, 10 Aug 2017 22:53:12 -0400 Message-ID: <1502419988.19230.16.camel@mtkswgap22> Subject: Re: [PATCH 1/2] dt-bindings: serial: Add MediaTek BTIF controller bindings From: Sean Wang To: Rob Herring CC: , , , , , , , , , , , , Date: Fri, 11 Aug 2017 10:53:08 +0800 In-Reply-To: <20170810162752.2xncymekrhu544g7@rob-hp-laptop> References: <6b2ad0dc976259563562e7ab23abdacf68c94aa5.1501692369.git.sean.wang@mediatek.com> <20170810162752.2xncymekrhu544g7@rob-hp-laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2395 Lines: 67 On Thu, 2017-08-10 at 11:27 -0500, Rob Herring wrote: > On Thu, Aug 03, 2017 at 01:05:22AM +0800, sean.wang@mediatek.com wrote: > > From: Sean Wang > > > > Document the devicetree bindings for MediaTek BTIF controller > > which could be found on MT7622 and MT7623 SoC. > > > > Signed-off-by: Sean Wang > > --- > > .../devicetree/bindings/serial/mtk-btif.txt | 26 ++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/serial/mtk-btif.txt > > > > diff --git a/Documentation/devicetree/bindings/serial/mtk-btif.txt b/Documentation/devicetree/bindings/serial/mtk-btif.txt > > new file mode 100644 > > index 0000000..80c1f5a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/mtk-btif.txt > > @@ -0,0 +1,26 @@ > > +Device-Tree bindings for MediaTek BTIF controller found on those > > +MediaTek SoCs with Bluetooth feature > > + > > +Required properties: > > +- compatible: Should be one of: > > + - "mediatek,mt7622-btif" : for MT7622 SoC > > + - "mediatek,mt7623-btif" : for MT7623 SoC > > +- reg: The base address of the BTIF register bank; > > +- interrupts: A single interrupt specifier; > > +- clocks: list of clock specifiers, corresponding to > > + entries in clock-names property; > > +- clock-names: should contain "main" entries. > > + > > +Optional properties: > > +- mediatek,loopback: Boolean; if defined, indicates that BTIF controller > > + running on the loopback mode. > > I don't think this belongs in DT, but should be a module param or sysfs > control. > the loopback actually is one of hardware setups so i add it as one property in the dt or could you kindly guide me how to make judgment accurately for listing those changes as either dt or a module param? > > + > > +Example: > > + > > + btif: btif@1100c000 { > > bluetooth@... > btif not bluetooth, which is just the interface hardware allowing the the main processor communicating with the bluetooth hardware built in the SoC, and is really like to the uart used by legacy bluetooth. So i will add bluetooth as the another node. > > + compatible = "mediatek,mt7623-btif"; > > + reg = <0 0x1100c000 0 0x1000>; > > + interrupts = ; > > + clocks = <&pericfg CLK_PERI_BTIF>; > > + clock-names = "main"; > > + }; > > -- > > 2.7.4 > >