Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbdHKDLV (ORCPT ); Thu, 10 Aug 2017 23:11:21 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:1792 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752133AbdHKDLT (ORCPT ); Thu, 10 Aug 2017 23:11:19 -0400 Message-ID: <1502421075.19230.23.camel@mtkswgap22> Subject: Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 From: Sean Wang To: Mark Brown CC: , , , , , , , , , , Date: Fri, 11 Aug 2017 11:11:15 +0800 In-Reply-To: <20170718133136.xodadxf2crkcuhze@sirena.org.uk> References: <0cd2be9a7058bb51fbbc7cc96101cba44fc081f6.1500368529.git.sean.wang@mediatek.com> <20170718133136.xodadxf2crkcuhze@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 32 On Tue, 2017-07-18 at 14:31 +0100, Mark Brown wrote: > On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@mediatek.com wrote: > > > + if (!info->modeset_mask) { > > + dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n", > > + info->desc.name); > > + return -EINVAL; > > + } > > This is mostly fine but the mode operations all have this code - if the > regulator doesn't have modesetting facilities it just shouldn't have > the ops so the core can handle things in a standard fashion. It'd mean > defining a separate set of operations for those regulators but that's > fine. Hi, Mark it is really bad for those calls with certain regulator always returning -EINVAL, that doesn't make sense. we'll follow your suggestion and add them into the next version. thanks for your help! Sean > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek