Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbdHKDM3 (ORCPT ); Thu, 10 Aug 2017 23:12:29 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:39997 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752147AbdHKDM2 (ORCPT ); Thu, 10 Aug 2017 23:12:28 -0400 Message-ID: <1502421143.19230.24.camel@mtkswgap22> Subject: Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 From: Sean Wang To: Yingjoe Chen CC: , , , , , , , , , , , Date: Fri, 11 Aug 2017 11:12:23 +0800 In-Reply-To: <1502270559.6566.14.camel@mtksdaap41> References: <0cd2be9a7058bb51fbbc7cc96101cba44fc081f6.1500368529.git.sean.wang@mediatek.com> <1502270559.6566.14.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3988 Lines: 102 On Wed, 2017-08-09 at 17:22 +0800, Yingjoe Chen wrote: > On Tue, 2017-07-18 at 17:49 +0800, sean.wang@mediatek.com wrote: > > From: Chenglin Xu > > > > The MT6380 is a regulator found those boards with MediaTek MT7622 SoC > > It is connected as a slave to the SoC using MediaTek PMIC wrapper which > > is the common interface connecting with Mediatek made various PMICs. > > > > Signed-off-by: Chenglin Xu > > Signed-off-by: Sean Wang > > --- > > drivers/regulator/Kconfig | 9 + > > drivers/regulator/Makefile | 1 + > > drivers/regulator/mt6380-regulator.c | 359 +++++++++++++++++++++++++++++ > > include/linux/regulator/mt6380-regulator.h | 32 +++ > > 4 files changed, 401 insertions(+) > > create mode 100644 drivers/regulator/mt6380-regulator.c > > create mode 100644 include/linux/regulator/mt6380-regulator.h > > > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > > index 48db87d..c46ef9c 100644 > > --- a/drivers/regulator/Kconfig > > +++ b/drivers/regulator/Kconfig > > @@ -541,6 +541,15 @@ config REGULATOR_MT6323 > > This driver supports the control of different power rails of device > > through regulator interface. > > > > +config REGULATOR_MT6380 > > + tristate "MediaTek MT6380 PMIC" > > + depends on MTK_PMIC_WRAP > > + help > > + Say y here to select this option to enable the power regulator of > > + MediaTek MT6380 PMIC. > > + This driver supports the control of different power rails of device > > + through regulator interface. > > + > > config REGULATOR_MT6397 > > tristate "MediaTek MT6397 PMIC" > > depends on MFD_MT6397 > > diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile > > index dc3503f..5148583 100644 > > --- a/drivers/regulator/Makefile > > +++ b/drivers/regulator/Makefile > > @@ -70,6 +70,7 @@ obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o > > obj-$(CONFIG_REGULATOR_MC13XXX_CORE) += mc13xxx-regulator-core.o > > obj-$(CONFIG_REGULATOR_MT6311) += mt6311-regulator.o > > obj-$(CONFIG_REGULATOR_MT6323) += mt6323-regulator.o > > +obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o > > obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o > > obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o > > obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o > > diff --git a/drivers/regulator/mt6380-regulator.c b/drivers/regulator/mt6380-regulator.c > > new file mode 100644 > > index 0000000..5fca36f > > --- /dev/null > > +++ b/drivers/regulator/mt6380-regulator.c > > <...> > > > +static struct regulator_ops mt6380_volt_range_ops = { > > + .list_voltage = regulator_list_voltage_linear_range, > > + .map_voltage = regulator_map_voltage_linear_range, > > + .set_voltage_sel = regulator_set_voltage_sel_regmap, > > + .get_voltage_sel = regulator_get_voltage_sel_regmap, > > + .set_voltage_time_sel = regulator_set_voltage_time_sel, > > + .enable = regulator_enable_regmap, > > + .disable = regulator_disable_regmap, > > + .is_enabled = regulator_is_enabled_regmap, > > + .set_mode = mt6380_regulator_set_mode, > > + .get_mode = mt6380_regulator_get_mode, > > +}; > > + > > +static struct regulator_ops mt6380_volt_table_ops = { > > + .list_voltage = regulator_list_voltage_table, > > + .map_voltage = regulator_map_voltage_iterate, > > + .set_voltage_sel = regulator_set_voltage_sel_regmap, > > + .get_voltage_sel = regulator_get_voltage_sel_regmap, > > + .set_voltage_time_sel = regulator_set_voltage_time_sel, > > + .enable = regulator_enable_regmap, > > + .disable = regulator_disable_regmap, > > + .is_enabled = regulator_is_enabled_regmap, > > + .set_mode = mt6380_regulator_set_mode, > > + .get_mode = mt6380_regulator_get_mode, > > +}; > > + > > +static struct regulator_ops mt6380_volt_fixed_ops = { > > this should be const. > > Joe.C Hi, Joe.C nice catch. also will be included in the next version Sean > >