Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752357AbdHKDbV (ORCPT ); Thu, 10 Aug 2017 23:31:21 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:34751 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbdHKDbU (ORCPT ); Thu, 10 Aug 2017 23:31:20 -0400 Date: Thu, 10 Aug 2017 20:31:15 -0700 From: Benson Leung To: Thierry Escande Cc: Benson Leung , Lee Jones , linux-kernel@vger.kernel.org, bleung@google.com, josephl@nvidia.com Subject: Re: [PATCH 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late Message-ID: <20170811033115.GA11011@decatoncale.mtv.corp.google.com> References: <1502403410-5233-1-git-send-email-thierry.escande@collabora.com> <1502403410-5233-3-git-send-email-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline In-Reply-To: <1502403410-5233-3-git-send-email-thierry.escande@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2011 Lines: 63 --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Thierry, On Fri, Aug 11, 2017 at 12:16:44AM +0200, Thierry Escande wrote: > From: Joseph Lo >=20 Again, please copy the original author. > The cros_ec_i2c driver is still active after it had suspended or before it > resumes. Besides that, it also tried to transfer data even after the I2C > host had been suspended. This leads the system to crash. >=20 > During the test, we also observed that the EC needs to be resumed > earlier due to some status polling from the EC firmware (e.g. battery > status). This patch moves the PM ops to late stage to make it work > normally. >=20 > Signed-off-by: Joseph Lo > Signed-off-by: Thierry Escande Acked-by: Benson Leung Thanks! Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZjSUDAAoJEB8J9XsKL+ZY4pAP/0RSaiR7ZRYhhOz6q16DaFQV NEUCIHHnxbglAVfxU+WW7hxDPa7P8AMLdixoxrCIkJwU0SuZChuwc1i3g6fno5AN Ij9h7fCcol1yuAgXBTACRFQS+YxIXlnug1hcMUEYapn9rpB7nYt+4NXElYvqxG9e jkkJ+i4Tk7g9eqsecKTRmaDVBPg/BXp6Y8++IFzn+iBURPVbmVjf7ZKmGCNU4Vdt U9dujvF4ikSh3K8nXtlUQURi+3f7NekEaPNtqabNpk6quyoPORhCMSeY2KR9zjPf zzR0LdVryzvwQpA7vk1L73Sz3CfTrVepVEszprvCbZH5hgg8BGM0EQ3K3NTaTGlB pjmF1nX9GCrmblY6B6kUWyNBcjjlg2dBejJ1V24OYHOTQFnkUUZbq4+DF0KlopyF O4Ondw0lnUh/uBYIHO4hzThK+Aq1aUsywGIE1iw/zyl+OGsQNS6+9i3ebtDHUAUh 0mu03PJXDu19rhVQKEnHwtUHStMbpSxiA7+UfJ2/+PblBXSk3sPUdbZeDRmYb3Vn 2g+ry8nEb2i4TyMYk/kOstDDin8Ye67k027CdTuZgjTHOIFUWU6CWyZWo05mNEwd lfs8gGu+QfkQr91UldBKzqto6/KNLU1giAEKxglNSP3Zol92Wv1rCL+IKuLFb2uP kL7gUa4U6haRMC43YfQL =5dk/ -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY--