Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721AbdHKEXe (ORCPT ); Fri, 11 Aug 2017 00:23:34 -0400 Received: from www1102.sakura.ne.jp ([219.94.129.142]:32275 "EHLO www1102.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbdHKEXd (ORCPT ); Fri, 11 Aug 2017 00:23:33 -0400 X-Greylist: delayed 522 seconds by postgrey-1.27 at vger.kernel.org; Fri, 11 Aug 2017 00:23:32 EDT Subject: Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control To: Masahiro Yamada Cc: Philipp Zabel , Jassi Brar , Masami Hiramatsu , linux-arm-kernel , Linux Kernel Mailing List References: <20170810072703.32433-1-suzuki.katsuhiro@socionext.com> <20170810072703.32433-3-suzuki.katsuhiro@socionext.com> <1502361454.10792.5.camel@pengutronix.de> From: Katsuhiro Suzuki Message-ID: <00020e70-8a53-a461-ccf4-1bd8247b4a23@katsuster.net> Date: Fri, 11 Aug 2017 13:23:30 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 48 Hi Yamada-san, On 2017年08月10日 20:23, Masahiro Yamada wrote: > Hi. > > > 2017-08-10 20:11 GMT+09:00 Masahiro Yamada : >> 2017-08-10 19:37 GMT+09:00 Philipp Zabel : >>> Hi Katsuhiro, >>> >>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote: >>>> Add a reset line for analog signal amplifier core (ADAMV) on >>>> UniPhier LD11/LD20 SoCs. >>>> >>>>> Signed-off-by: Katsuhiro Suzuki >>>> --- >>>> drivers/reset/reset-uniphier.c | 15 +++++++++++++++ >>>> 1 file changed, 15 insertions(+) >>>> >>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c >>>> index f60c137c17cb..cda4a78a58e2 100644 >>>> --- a/drivers/reset/reset-uniphier.c >>>> +++ b/drivers/reset/reset-uniphier.c >>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = { >>>>> UNIPHIER_RESET_END, >>>> }; >>>> >>>> +/* Analog signal amplifiers reset data */ >>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = { >>>>> + UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */ >>>>> + UNIPHIER_RESET_END, >>>> +}; > > > I take back my Acked-by. > > > The reset line index is independent from others > because this block is a separate instance. > > Are you OK with starting from the reset ID 100? It's my mistake. This ID can start with 0. I will fix in next V2 series, thank you. Regards, -- Katsuhiro Suzuki