Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752383AbdHKE4i (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 00:56:38 -0400
Received: from www1102.sakura.ne.jp ([219.94.129.142]:28572 "EHLO
        www1102.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751233AbdHKE4h (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 00:56:37 -0400
Subject: Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control
To: Philipp Zabel <p.zabel@pengutronix.de>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-arm-kernel@lists.infradead.org
Cc: Jassi Brar <jaswinder.singh@linaro.org>, linux-kernel@vger.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>
References: <20170810072703.32433-1-suzuki.katsuhiro@socionext.com>
 <20170810072703.32433-3-suzuki.katsuhiro@socionext.com>
 <1502361454.10792.5.camel@pengutronix.de>
From: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
Message-ID: <1e6531e9-4c0a-e16b-3edf-f86ec6264570@katsuster.net>
Date: Fri, 11 Aug 2017 13:14:48 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1502361454.10792.5.camel@pengutronix.de>
Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1874
Lines: 58

Hi Philipp,

On 2017年08月10日 19:37, Philipp Zabel wrote:
> Hi Katsuhiro,
> 
> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>> Add a reset line for analog signal amplifier core (ADAMV) on
>> UniPhier LD11/LD20 SoCs.
>>
>>> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
>> ---
>>   drivers/reset/reset-uniphier.c | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>> index f60c137c17cb..cda4a78a58e2 100644
>> --- a/drivers/reset/reset-uniphier.c
>> +++ b/drivers/reset/reset-uniphier.c
>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data uniphier_pro4_peri_reset_data[] = {
>>>   	UNIPHIER_RESET_END,
>>   };
>>   
>> +/* Analog signal amplifiers reset data */
>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
>>> +	UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>>> +	UNIPHIER_RESET_END,
>> +};
>> +
>>   /* core implementaton */
>>   struct uniphier_reset_priv {
>>>   	struct reset_controller_dev rcdev;
>> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {
>>>   		.compatible = "socionext,uniphier-ld20-peri-reset",
>>>   		.data = uniphier_pro4_peri_reset_data,
>>>   	},
>>> +	/* Analog signal amplifiers reset */
>>> +	{
>>> +		.compatible = "socionext,uniphier-ld11-adamv-reset",
>>> +		.data = uniphier_ld11_adamv_reset_data,
>>> +	},
>>> +	{
>>> +		.compatible = "socionext,uniphier-ld20-adamv-reset",
>>> +		.data = uniphier_ld11_adamv_reset_data,
>>> +	},
>>>   	{ /* sentinel */ }
>>   };
>>   MODULE_DEVICE_TABLE(of, uniphier_reset_match);
> 
> Please add a patch to describe the new compatible values in
> Documentation/devicetree/bindings/reset/uniphier-reset.txt.
> 

Thank you, I will add it and send V2 series.


Regards,
--
Katsuhiro Suzuki