Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752312AbdHKGNq (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 02:13:46 -0400
Received: from mailgw02.mediatek.com ([210.61.82.184]:2446 "EHLO
        mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1752047AbdHKGNp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 02:13:45 -0400
Message-ID: <1502432018.19230.29.camel@mtkswgap22>
Subject: Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for
 MediaTek MT6380 regulator
From: Sean Wang <sean.wang@mediatek.com>
To: Rob Herring <robh@kernel.org>
CC: <matthias.bgg@gmail.com>, <mark.rutland@arm.com>,
        <lgirdwood@gmail.com>, <broonie@kernel.org>,
        <jamesjj.liao@mediatek.com>, <henryc.chen@mediatek.com>,
        <devicetree@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
        <chen.zhong@mediatek.com>, <chenglin.xu@mediatek.com>,
        <linux-kernel@vger.kernel.org>
Date: Fri, 11 Aug 2017 14:13:38 +0800
In-Reply-To: <20170724182242.ejrobnjks3ehprpw@rob-hp-laptop>
References: <cover.1500368529.git.sean.wang@mediatek.com>
         <fef9412087f3961e03b77c067e227a31860a1417.1500368529.git.sean.wang@mediatek.com>
         <20170724182242.ejrobnjks3ehprpw@rob-hp-laptop>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1811
Lines: 47

On Mon, 2017-07-24 at 13:22 -0500, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 05:49:22PM +0800, sean.wang@mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> > 
> > add dt-binding document for MediaTek MT6380 PMIC
> > 
> > Signed-off-by: Chenglin Xu <chenglin.xu@mediatek.com>
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > ---
> >  .../bindings/regulator/mt6380-regulator.txt        | 90 ++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > new file mode 100644
> > index 0000000..2a559f0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > @@ -0,0 +1,90 @@
> > +MediaTek MT6380 Regulator Driver
> 
> Bindings don't describe drivers.
> 
will fix it.

> > +
> > +All voltage regulators are defined as subnodes of the regulators node. A list
> 
> What's the regulators node a child of?
> 

this two line i felt are a little confusion, i will change them into "
all voltage regulators provided by the MT6380 PMIC are described as the
subnodes of the mt6380regulators node "

> > +of regulators provided by this controller are defined as subnodes of the
> > +PMIC's node. Each regulator is named according to its regulator type,
> > +buck-<name> and ldo-<name>. The definition for each of these nodes is defined
> > +using the standard binding for regulators at
> > +Documentation/devicetree/bindings/regulator/regulator.txt.
> > +
> > +The valid names for regulators are:
> > +BUCK:
> > +  buck-core1, buck-vcore, buck-vrf
> > +LDO:
> > +  ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt