Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147AbdHKGo5 (ORCPT ); Fri, 11 Aug 2017 02:44:57 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:55563 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdHKGo4 (ORCPT ); Fri, 11 Aug 2017 02:44:56 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: wxt@rock-chips.com X-SENDER-IP: 103.29.143.42 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <0d3a8ca5a31213c5b38f38a1f402934f> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC To: Rocky Hao , rui.zhang@intel.com, edubezval@gmail.com, heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: huangtao@rock-chips.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, shawn.lin@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, cl@rock-chips.com, william.wu@rock-chips.com, jay.xu@rock-chips.com, xxx@rock-chips.com, linux-arm-kernel@lists.infradead.org, wxt@rock-chips.com References: <1501833976-1100-1-git-send-email-rocky.hao@rock-chips.com> <1501833976-1100-5-git-send-email-rocky.hao@rock-chips.com> From: Caesar Wang Message-ID: Date: Fri, 11 Aug 2017 14:44:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501833976-1100-5-git-send-email-rocky.hao@rock-chips.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3134 Lines: 104 ?? 2017??08??04?? 16:06, Rocky Hao ะด??: > add thermal zone and dynamic CPU power coefficients for rk3328 > > Signed-off-by: Rocky Hao > --- > Change in v2: > - remove gerrit Change-Id > > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 ++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index 186fb93fdffd..68829f808320 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -47,6 +47,7 @@ > #include > #include > #include > +#include > > / { > compatible = "rockchip,rk3328"; > @@ -74,6 +75,8 @@ > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x0>; > clocks = <&cru ARMCLK>; > + #cooling-cells = <2>; /* min followed by max */ > + dynamic-power-coefficient = <120>; > enable-method = "psci"; > next-level-cache = <&l2>; > }; > @@ -83,6 +86,7 @@ > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x1>; > clocks = <&cru ARMCLK>; > + dynamic-power-coefficient = <120>; > enable-method = "psci"; > next-level-cache = <&l2>; > }; > @@ -92,6 +96,7 @@ > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x2>; > clocks = <&cru ARMCLK>; > + dynamic-power-coefficient = <120>; > enable-method = "psci"; > next-level-cache = <&l2>; > }; > @@ -101,6 +106,7 @@ > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x3>; > clocks = <&cru ARMCLK>; > + dynamic-power-coefficient = <120>; > enable-method = "psci"; > next-level-cache = <&l2>; > }; > @@ -308,6 +314,43 @@ > interrupts = ; > }; > > + thermal-zones { > + soc_thermal: soc-thermal { > + polling-delay-passive = <20>; /* milliseconds */ > + polling-delay = <1000>; /* milliseconds */ > + sustainable-power = <1000>; /* milliwatts */ > + > + thermal-sensors = <&tsadc 0>; > + > + trips { > + threshold: trip-point0 { > + temperature = <70000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + target: trip-point1 { > + temperature = <85000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + soc_crit: soc-crit { > + temperature = <95000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ The document had already described, maybe we should remove the millicelsius/milliseconds/milliwatts here. > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&target>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + contribution = <4096>; > + }; > + }; > + }; > + > + }; > + > tsadc: tsadc@ff250000 { > compatible = "rockchip,rk3328-tsadc"; > reg = <0x0 0xff250000 0x0 0x100>;