Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbdHKJEi (ORCPT ); Fri, 11 Aug 2017 05:04:38 -0400 Received: from mail.skyhub.de ([5.9.137.197]:39568 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbdHKJEg (ORCPT ); Fri, 11 Aug 2017 05:04:36 -0400 Date: Fri, 11 Aug 2017 11:04:14 +0200 From: Borislav Petkov To: "Kani, Toshimitsu" Cc: "linux-acpi@vger.kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "rjw@rjwysocki.net" Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Message-ID: <20170811090414.GB9432@nazgul.tnic> References: <20170803215753.30553-1-toshi.kani@hpe.com> <20170803215753.30553-5-toshi.kani@hpe.com> <20170804040525.GE12082@nazgul.tnic> <1501879964.2042.117.camel@hpe.com> <20170805051615.GC23214@nazgul.tnic> <1502128177.2042.131.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1502128177.2042.131.camel@hpe.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 512 Lines: 17 On Mon, Aug 07, 2017 at 05:59:15PM +0000, Kani, Toshimitsu wrote: > I think we should keep the current scheme, which registers an mci for No we shouldn't. > each GHES entry. ghes_edac_report_mem_error() expects that error- > reporting is serialized per a GHES entry. Sharing a single mci among > all GHES entries / error interfaces might lead to a race condition. See how I solved it in my patchset and feel free to reuse it. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --