Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbdHKJrI (ORCPT ); Fri, 11 Aug 2017 05:47:08 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:39310 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdHKJrG (ORCPT ); Fri, 11 Aug 2017 05:47:06 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: rocky.hao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: rocky.hao@rock-chips.com X-UNIQUE-TAG: <97de48fad0df4ed41864dfcdbaea3113> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC To: Caesar Wang , rui.zhang@intel.com, edubezval@gmail.com, heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: huangtao@rock-chips.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, shawn.lin@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, cl@rock-chips.com, william.wu@rock-chips.com, jay.xu@rock-chips.com, xxx@rock-chips.com, linux-arm-kernel@lists.infradead.org References: <1501833976-1100-1-git-send-email-rocky.hao@rock-chips.com> <1501833976-1100-5-git-send-email-rocky.hao@rock-chips.com> From: "rocky.hao" Message-ID: Date: Fri, 11 Aug 2017 17:46:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4008 Lines: 116 Hi Caesar, Thanks for your comments. Best Regards, Rocky ?? 2017/8/11 14:44, Caesar Wang д??: > ?? 2017??08??04?? 16:06, Rocky Hao д??: >> add thermal zone and dynamic CPU power coefficients for rk3328 >> >> Signed-off-by: Rocky Hao >> --- >> Change in v2: >> - remove gerrit Change-Id >> >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 >> ++++++++++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> index 186fb93fdffd..68829f808320 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> @@ -47,6 +47,7 @@ >> #include >> #include >> #include >> +#include >> / { >> compatible = "rockchip,rk3328"; >> @@ -74,6 +75,8 @@ >> compatible = "arm,cortex-a53", "arm,armv8"; >> reg = <0x0 0x0>; >> clocks = <&cru ARMCLK>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <120>; >> enable-method = "psci"; >> next-level-cache = <&l2>; >> }; >> @@ -83,6 +86,7 @@ >> compatible = "arm,cortex-a53", "arm,armv8"; >> reg = <0x0 0x1>; >> clocks = <&cru ARMCLK>; >> + dynamic-power-coefficient = <120>; >> enable-method = "psci"; >> next-level-cache = <&l2>; >> }; >> @@ -92,6 +96,7 @@ >> compatible = "arm,cortex-a53", "arm,armv8"; >> reg = <0x0 0x2>; >> clocks = <&cru ARMCLK>; >> + dynamic-power-coefficient = <120>; >> enable-method = "psci"; >> next-level-cache = <&l2>; >> }; >> @@ -101,6 +106,7 @@ >> compatible = "arm,cortex-a53", "arm,armv8"; >> reg = <0x0 0x3>; >> clocks = <&cru ARMCLK>; >> + dynamic-power-coefficient = <120>; >> enable-method = "psci"; >> next-level-cache = <&l2>; >> }; >> @@ -308,6 +314,43 @@ >> interrupts = ; >> }; >> + thermal-zones { >> + soc_thermal: soc-thermal { >> + polling-delay-passive = <20>; /* milliseconds */ >> + polling-delay = <1000>; /* milliseconds */ >> + sustainable-power = <1000>; /* milliwatts */ >> + >> + thermal-sensors = <&tsadc 0>; >> + >> + trips { >> + threshold: trip-point0 { >> + temperature = <70000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + target: trip-point1 { >> + temperature = <85000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + soc_crit: soc-crit { >> + temperature = <95000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ > > The document had already described, maybe we should remove the > millicelsius/milliseconds/milliwatts here. It is ok for me. >> + type = "critical"; >> + }; >> + }; >> + >> + cooling-maps { >> + map0 { >> + trip = <&target>; >> + cooling-device = <&cpu0 THERMAL_NO_LIMIT >> THERMAL_NO_LIMIT>; >> + contribution = <4096>; >> + }; >> + }; >> + }; >> + >> + }; >> + >> tsadc: tsadc@ff250000 { >> compatible = "rockchip,rk3328-tsadc"; >> reg = <0x0 0xff250000 0x0 0x100>; > > > >