Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753101AbdHKMT7 (ORCPT ); Fri, 11 Aug 2017 08:19:59 -0400 Received: from ozlabs.org ([103.22.144.67]:49725 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074AbdHKMT5 (ORCPT ); Fri, 11 Aug 2017 08:19:57 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: cffb717ceb8e2ca0316e89d908db54af454f1fbb In-Reply-To: <20170803013822.GD28905@us.ibm.com> To: Sukadev Bhattiprolu From: Michael Ellerman Cc: tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: powerpc: xive: ensure active irqd when setting affinity Message-Id: <3xTPG360xZz9t32@ozlabs.org> Date: Fri, 11 Aug 2017 22:19:55 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 26 On Thu, 2017-08-03 at 01:38:22 UTC, Sukadev Bhattiprolu wrote: > >From fd0abf5c61b6041fdb75296e8580b86dc91d08d6 Mon Sep 17 00:00:00 2001 > From: Benjamin Herrenschmidt > Date: Tue, 1 Aug 2017 20:54:41 -0500 > Subject: [PATCH] powerpc: xive: ensure active irqd when setting affinity > > Ensure irqd is active before attempting to set affinity. This should > make the set affinity code more robust. For instance, this prevents > these messages seen on a 4.12 based kernel when taking cpus offline: > > [ 123.053037264,3] XIVE[ IC 00 ] ISN 2 lead to invalid IVE ! > [ 77.885859] xive: Error -6 reconfiguring irq 17 > [ 77.885862] IRQ17: set affinity failed(-6). > > The underlying problem with taking cpus offline was fixed in 4.13-rc1 by: > > commit 91f26cb4cd3c ("genirq/cpuhotplug: Do not migrated shutdown irqs") > > Signed-off-by: Sukadev Bhattiprolu > Signed-off-by: Benjamin Herrenschmidt Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/cffb717ceb8e2ca0316e89d908db54 cheers