Subject: Re: [PATCH v2] ASoC: samsung: i2s: Null pointer dereference on
 samsung_i2s_remove
To: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
        Sangbeom Kim <sbkim73@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-id: <029a9c75-b8ca-1969-d846-fb49c4bc41bf@samsung.com>
Date: Fri, 11 Aug 2017 15:00:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.2.1
MIME-version: 1.0
In-reply-to: <1502454942-739-1-git-send-email-vasilyev@ispras.ru>
Content-type: text/plain; charset="utf-8"; format="flowed"
Content-language: en-GB
Content-transfer-encoding: 7bit
CMS-TYPE: 102P
References: <CGME20170811123601epcas4p49ca200aaa39cae3fa0f6cba5bf86f1f8@epcas4p4.samsung.com>
        <1502454942-739-1-git-send-email-vasilyev@ispras.ru>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 554
Lines: 15

On 08/11/2017 02:35 PM, Anton Vasilyev wrote:
> If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate
> sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove()
> permorms pri_dai->sec_dai dereference in any case.
   ^^^^^^^^
Still you have a typo here. ;)

> The patch adds sec_dai check on Null before derefence at
> samsung_i2s_remove().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Vasilyev<vasilyev@ispras.ru>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>