Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbdHKNBr (ORCPT ); Fri, 11 Aug 2017 09:01:47 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:43343 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168AbdHKNBo (ORCPT ); Fri, 11 Aug 2017 09:01:44 -0400 Message-ID: <1502456500.2310.14.camel@pengutronix.de> Subject: Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers From: Philipp Zabel To: Cihangir Akturk Cc: CK Hu , daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Fri, 11 Aug 2017 15:01:40 +0200 In-Reply-To: <1502454794-28558-14-git-send-email-cakturk@gmail.com> References: <1502454794-28558-1-git-send-email-cakturk@gmail.com> <1502454794-28558-14-git-send-email-cakturk@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2044 Lines: 61 On Fri, 2017-08-11 at 15:32 +0300, Cihangir Akturk wrote: > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() > and drm_*_unreference() helpers. > > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() and should not be > used by new code. So convert all users of compatibility functions to > use the new APIs. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Cihangir Akturk > --- >  drivers/gpu/drm/mediatek/mtk_drm_fb.c  | 4 ++-- >  drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- >  2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > index d4246c9..0d8d506 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > @@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct > drm_framebuffer *fb) >   >   drm_framebuffer_cleanup(fb); >   > - drm_gem_object_unreference_unlocked(mtk_fb->gem_obj); > + drm_gem_object_put_unlocked(mtk_fb->gem_obj); >   >   kfree(mtk_fb); >  } > @@ -160,6 +160,6 @@ struct drm_framebuffer > *mtk_drm_mode_fb_create(struct drm_device *dev, >   return &mtk_fb->base; >   >  unreference: > - drm_gem_object_unreference_unlocked(gem); > + drm_gem_object_put_unlocked(gem); >   return ERR_PTR(ret); >  } > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > index 8ec963f..f595ac8 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > @@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file > *file_priv, struct drm_device *dev, >   goto err_handle_create; >   >   /* drop reference from allocate - handle holds it now. */ > - drm_gem_object_unreference_unlocked(&mtk_gem->base); > + drm_gem_object_put_unlocked(&mtk_gem->base); >   >   return 0; >   Reviewed-by: Philipp Zabel regards Philipp