DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BFD346081B
Subject: Re: [PATCH] acpi: apei: fix the wrongly parse generic error status
 block
To: gengdongjiu <gengdongjiu@huawei.com>, rjw@rjwysocki.net,
        lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1502388412-20273-1-git-send-email-gengdongjiu@huawei.com>
 <9ea70eed-f743-0c8b-2a70-27ce4c0d8705@codeaurora.org>
 <ddb2070d-60c5-a476-c003-25814d0cf863@huawei.com>
 <1be489f7-c1c3-63dc-dc0d-af67e5fd03a1@huawei.com>
From: "Baicar, Tyler" <tbaicar@codeaurora.org>
Message-ID: <70ebfc99-0666-fa2b-8ed4-19e1f93194bd@codeaurora.org>
Date: Fri, 11 Aug 2017 07:19:58 -0600
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1be489f7-c1c3-63dc-dc0d-af67e5fd03a1@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2910
Lines: 67

I removed the apei_estatus_for_each_section because it was only being 
used in this one spot even though several other parts of the code do the 
same iteration (it is done several times in the CPER code). I made this 
iteration match the CPER iterations because the CPER iterations are 
verifying that the structures are all valid and lengths are correct. If 
those checks are being done this way, it makes the most sense to mimic 
that iteration here when calling into EDAC and triggering trace events.

Thanks,

Tyler


On 8/10/2017 3:37 PM, gengdongjiu wrote:
> may be directly remove the macro apei_estatus_for_each_section is not better, if other place code also
> needs to iterate through the GHES estatus blocks, it will be repeated written again.
>
>
> On 2017/8/11 5:31, gengdongjiu wrote:
>> Hello,
>>
>>     sorry, I do not see that. Just know I have reviewed your modification, may be my change can be simpleness and reserve the macro of apei_estatus_for_each_section
>> can be used by other place to avoid duplicated code, such as prints the estatus blocks.
>>
>> On 2017/8/11 1:48, Baicar, Tyler wrote:
>>> Hello,
>>>
>>> I have already posted a patch fixing this. Please see:
>>>
>>> https://lkml.org/lkml/2017/8/3/824
>>>
>>> This makes the loop identical to the CPER code which prints the estatus blocks to the kernel logs.
>>>
>>> Thanks,
>>>
>>> Tyler
>>>
>>>
>>> On 8/10/2017 12:06 PM, Dongjiu Geng wrote:
>>>> The revision 0x300 generic error data entry is different with the old
>>>> version. when ghes_do_proc traverses to get the data entry, it does not
>>>> consider this difference. so when error status block has revision 0x300
>>>> data entry, it will have issue.
>>>>
>>>> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
>>>> ---
>>>>    drivers/acpi/apei/apei-internal.h | 4 ++--
>>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/acpi/apei/apei-internal.h b/drivers/acpi/apei/apei-internal.h
>>>> index 6e9f14c0a71b..6491f1c4a96e 100644
>>>> --- a/drivers/acpi/apei/apei-internal.h
>>>> +++ b/drivers/acpi/apei/apei-internal.h
>>>> @@ -122,8 +122,8 @@ struct dentry *apei_get_debugfs_dir(void);
>>>>      #define apei_estatus_for_each_section(estatus, section)            \
>>>>        for (section = (struct acpi_hest_generic_data *)(estatus + 1);    \
>>>> -         (void *)section - (void *)estatus < estatus->data_length;    \
>>>> -         section = (void *)(section+1) + section->error_data_length)
>>>> +         (void *)section - (void *)(estatus + 1) < estatus->data_length; \
>>>> +         section = acpi_hest_get_next(section))
>>>>      static inline u32 cper_estatus_len(struct acpi_hest_generic_status *estatus)
>>>>    {

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.