Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbdHKPPw (ORCPT ); Fri, 11 Aug 2017 11:15:52 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:33711 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbdHKPPv (ORCPT ); Fri, 11 Aug 2017 11:15:51 -0400 Subject: Re: [PATCH v3 2/5] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt To: Mark Brown Cc: Banajit Goswami , alsa-devel@alsa-project.org, damien.riegel@savoirfairelinux.com, Jaroslav Kysela , Takashi Iwai , Patrick Lai , linux-kernel@vger.kernel.org References: <20170809164927.19663-1-srinivas.kandagatla@linaro.org> <20170809164927.19663-3-srinivas.kandagatla@linaro.org> <20170810152437.ezfhi7cukutyabmt@sirena.org.uk> From: Srinivas Kandagatla Message-ID: <5a6db43c-3ba4-aba7-977e-0ea731d4f2f9@linaro.org> Date: Fri, 11 Aug 2017 16:15:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810152437.ezfhi7cukutyabmt@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 17 On 10/08/17 16:24, Mark Brown wrote: > On Wed, Aug 09, 2017 at 06:49:24PM +0200, srinivas.kandagatla@linaro.org wrote: > >> - snd_soc_write(codec, CDC_A_MICB_1_VAL, MICB_1_VAL_MICB_OUT_VAL_V2P70V); >> - /* >> - * Special headset needs MICBIAS as 2.7V so wait for >> - * 50 msec for the MICBIAS to reach 2.7 volts. >> - */ >> - msleep(50); >> + if (wcd->micbias_mv) > > We seem to have just completely lost this ramp time handling? Yes, will take care of this in next version. >