Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753330AbdHKPVj (ORCPT ); Fri, 11 Aug 2017 11:21:39 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33246 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753158AbdHKPVg (ORCPT ); Fri, 11 Aug 2017 11:21:36 -0400 Date: Fri, 11 Aug 2017 18:21:31 +0300 From: Cihangir Akturk To: "Deucher, Alexander" Cc: "devel@driverdev.osuosl.org" , "linux-arm-msm@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "etnaviv@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "daniel@ffwll.ch" , "nouveau@lists.freedesktop.org" , "linux-tegra@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "freedreno@lists.freedesktop.org" Subject: Re: [PATCH v3 00/28] DRM API Conversions Message-ID: <20170811152131.GB14080@yoga.localdomain> References: <1502454794-28558-1-git-send-email-cakturk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 12203 Lines: 231 On Fri, Aug 11, 2017 at 02:24:19PM +0000, Deucher, Alexander wrote: > > -----Original Message----- > > From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf > > Of Cihangir Akturk > > Sent: Friday, August 11, 2017 8:33 AM > > Cc: devel@driverdev.osuosl.org; linux-arm-msm@vger.kernel.org; intel- > > gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; dri- > > devel@lists.freedesktop.org; etnaviv@lists.freedesktop.org; Cihangir Akturk; > > amd-gfx@lists.freedesktop.org; daniel@ffwll.ch; > > nouveau@lists.freedesktop.org; linux-tegra@vger.kernel.org; > > virtualization@lists.linux-foundation.org; freedreno@lists.freedesktop.org > > Subject: [PATCH v3 00/28] DRM API Conversions > > > > Changes since v2: > > > > - Patch series is based on *drm-misc-next* as suggested by Sean Paul. > > > > - Dropped patch 05 (drm/atmel-hlcdc) and patch 25 (drm/vc4) from v2, > > since they were already pulled in the drm-misc-next > > > > Changes since v1: > > > > - This time patches were generated with coccinelle instead of my own > > script, as suggested by Daniel Vetter. > > > > - Fixed the typo in commit messages. s/adn/and > > > > FWIW, I already picked up v1 of these patches for radeon and amdgpu. I think you can skip these patches of v3 for amdgpu and radeon, as they have remained unchanged since v1. > > Alex > > > Note: I've included r-b, a-b tags, as these patches are identical to v1 > > except for the file: drivers/gpu/drm/i915/i915_gem_object.h > > > > This patch set replaces the occurrences of drm_*_reference() and > > drm_*_unreference() with the new drm_*_get() and drm_*_put() > > functions. > > All patches in the series do the same thing, converting to the new APIs. > > I created patches per DRM driver as suggested by Daniel Vetter. > > > > This patch set was generated by scripts/coccinelle/api/drm-get-put.cocci > > > > Previous thread can be reached at: > > https://marc.info/?l=dri-devel&m=150178288816047 > > > > Background: > > > > In the kernel, reference counting APIs use *_get(), *_put() style naming > > to reference-count the objects. But DRM subsystem uses a different > > naming for them such as *_reference(), *_unreference() which is > > inconsistent with the other reference counting APIs in the kernel. To > > solve this consistency issue, Thierry Reding introduced a couple of > > functions and compatibility aliases in the following commits for them. > > > > commit 020a218f95bd3ceff7dd1022ff7ebc0497bc7bf9 > > Author: Thierry Reding > > Date: Tue Feb 28 15:46:38 2017 +0100 > > > > drm: Introduce drm_mode_object_{get,put}() > > > > commit ad09360750afa18a0a0ce0253d6ea6033abc22e7 > > Author: Thierry Reding > > Date: Tue Feb 28 15:46:39 2017 +0100 > > > > drm: Introduce drm_connector_{get,put}() > > > > commit a4a69da06bc11a937a6e417938b1bb698ee1fa46 > > Author: Thierry Reding > > Date: Tue Feb 28 15:46:40 2017 +0100 > > > > drm: Introduce drm_framebuffer_{get,put}() > > > > commit e6b62714e87c8811d5564b6a0738dcde63a51774 > > Author: Thierry Reding > > Date: Tue Feb 28 15:46:41 2017 +0100 > > > > drm: Introduce drm_gem_object_{get,put}() > > > > commit 6472e5090be7c78749a3c279b4faae87ab835c40 > > Author: Thierry Reding > > Date: Tue Feb 28 15:46:42 2017 +0100 > > > > drm: Introduce drm_property_blob_{get,put}() > > > > Cihangir Akturk (28): > > drm/amdgpu: switch to drm_*_get(), drm_*_put() helpers > > drm: mali-dp: switch to drm_*_get(), drm_*_put() helpers > > drm/armada: switch to drm_*_get(), drm_*_put() helpers > > drm/ast: switch to drm_*_get(), drm_*_put() helpers > > drm/bochs: switch to drm_*_get(), drm_*_put() helpers > > drm/cirrus: switch to drm_*_get(), drm_*_put() helpers > > drm/etnaviv: switch to drm_*_get(), drm_*_put() helpers > > drm/exynos: switch to drm_*_get(), drm_*_put() helpers > > drm/gma500: switch to drm_*_get(), drm_*_put() helpers > > drm/hisilicon: switch to drm_*_get(), drm_*_put() helpers > > drm/i915: switch to drm_*_get(), drm_*_put() helpers > > drm/imx: switch to drm_*_get(), drm_*_put() helpers > > drm/mediatek: switch to drm_*_get(), drm_*_put() helpers > > drm/mgag200: switch to drm_*_get(), drm_*_put() helpers > > drm/msm: switch to drm_*_get(), drm_*_put() helpers > > drm/nouveau: switch to drm_*_get(), drm_*_put() helpers > > drm/omapdrm: switch to drm_*_get(), drm_*_put() helpers > > drm/qxl: switch to drm_*_get(), drm_*_put() helpers > > drm/radeon: switch to drm_*_get(), drm_*_put() helpers > > drm/rockchip: switch to drm_*_get(), drm_*_put() helpers > > drm/tegra: switch to drm_*_get(), drm_*_put() helpers > > drm/tilcdc: switch to drm_*_get(), drm_*_put() helpers > > drm/udl: switch to drm_*_get(), drm_*_put() helpers > > drm/vc4: switch to drm_*_get(), drm_*_put() helpers > > drm/vgem: switch to drm_*_get(), drm_*_put() helpers > > drm/virtio: switch to drm_*_get(), drm_*_put() helpers > > drm/vmwgfx: switch to drm_*_get(), drm_*_put() helpers > > drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- > > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 ++--- > > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 +-- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 22 ++++++++--------- > > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 6 ++--- > > drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 6 ++--- > > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 6 ++--- > > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 6 ++--- > > drivers/gpu/drm/arm/malidp_planes.c | 2 +- > > drivers/gpu/drm/armada/armada_crtc.c | 22 ++++++++--------- > > drivers/gpu/drm/armada/armada_drv.c | 2 +- > > drivers/gpu/drm/armada/armada_fb.c | 8 +++--- > > drivers/gpu/drm/armada/armada_fbdev.c | 6 ++--- > > drivers/gpu/drm/armada/armada_gem.c | 14 +++++------ > > drivers/gpu/drm/armada/armada_overlay.c | 4 +-- > > drivers/gpu/drm/ast/ast_fb.c | 2 +- > > drivers/gpu/drm/ast/ast_main.c | 10 ++++---- > > drivers/gpu/drm/ast/ast_mode.c | 6 ++--- > > drivers/gpu/drm/bochs/bochs_fbdev.c | 2 +- > > drivers/gpu/drm/bochs/bochs_mm.c | 10 ++++---- > > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 +- > > drivers/gpu/drm/cirrus/cirrus_main.c | 10 ++++---- > > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 +++--- > > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 20 +++++++-------- > > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- > > drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 +-- > > drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 +-- > > drivers/gpu/drm/exynos/exynos_drm_gem.c | 12 ++++----- > > drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +- > > drivers/gpu/drm/gma500/framebuffer.c | 4 +-- > > drivers/gpu/drm/gma500/gem.c | 4 +-- > > drivers/gpu/drm/gma500/gma_display.c | 6 ++--- > > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 4 +-- > > drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 8 +++--- > > drivers/gpu/drm/i915/i915_gem_object.h | 4 +-- > > drivers/gpu/drm/i915/intel_display.c | 24 +++++++++--------- > > drivers/gpu/drm/i915/intel_dp_mst.c | 2 +- > > drivers/gpu/drm/i915/intel_fbdev.c | 4 +-- > > drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- > > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 4 +-- > > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > > drivers/gpu/drm/mgag200/mgag200_cursor.c | 2 +- > > drivers/gpu/drm/mgag200/mgag200_fb.c | 4 +-- > > drivers/gpu/drm/mgag200/mgag200_main.c | 10 ++++---- > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 10 ++++---- > > drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++--- > > drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 2 +- > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 +- > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 4 +-- > > drivers/gpu/drm/msm/msm_drv.c | 8 +++--- > > drivers/gpu/drm/msm/msm_fb.c | 4 +-- > > drivers/gpu/drm/msm/msm_fbdev.c | 2 +- > > drivers/gpu/drm/msm/msm_gem.c | 8 +++--- > > drivers/gpu/drm/msm/msm_gem_submit.c | 4 +-- > > drivers/gpu/drm/msm/msm_gpu.c | 4 +-- > > drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +- > > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 2 +- > > drivers/gpu/drm/nouveau/nouveau_abi16.c | 2 +- > > drivers/gpu/drm/nouveau/nouveau_display.c | 8 +++--- > > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- > > drivers/gpu/drm/nouveau/nouveau_gem.c | 14 +++++------ > > drivers/gpu/drm/nouveau/nv50_display.c | 2 +- > > drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- > > drivers/gpu/drm/omapdrm/omap_fb.c | 4 +-- > > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- > > drivers/gpu/drm/omapdrm/omap_gem.c | 4 +-- > > drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 2 +- > > drivers/gpu/drm/qxl/qxl_display.c | 4 +-- > > drivers/gpu/drm/qxl/qxl_dumb.c | 2 +- > > drivers/gpu/drm/qxl/qxl_fb.c | 6 ++--- > > drivers/gpu/drm/qxl/qxl_gem.c | 2 +- > > drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +-- > > drivers/gpu/drm/qxl/qxl_object.c | 6 ++--- > > drivers/gpu/drm/radeon/radeon_cs.c | 2 +- > > drivers/gpu/drm/radeon/radeon_cursor.c | 6 ++--- > > drivers/gpu/drm/radeon/radeon_display.c | 12 ++++----- > > drivers/gpu/drm/radeon/radeon_fb.c | 4 +-- > > drivers/gpu/drm/radeon/radeon_gem.c | 30 +++++++++++------------ > > drivers/gpu/drm/radeon/radeon_object.c | 2 +- > > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 6 ++--- > > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- > > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +-- > > drivers/gpu/drm/tegra/drm.c | 12 ++++----- > > drivers/gpu/drm/tegra/fb.c | 8 +++--- > > drivers/gpu/drm/tegra/gem.c | 10 ++++---- > > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 ++--- > > drivers/gpu/drm/udl/udl_fb.c | 6 ++--- > > drivers/gpu/drm/udl/udl_gem.c | 4 +-- > > drivers/gpu/drm/vc4/vc4_bo.c | 2 +- > > drivers/gpu/drm/vgem/vgem_drv.c | 4 +-- > > drivers/gpu/drm/vgem/vgem_fence.c | 2 +- > > drivers/gpu/drm/virtio/virtgpu_display.c | 4 +-- > > drivers/gpu/drm/virtio/virtgpu_gem.c | 4 +-- > > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 14 +++++------ > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 4 +-- > > drivers/staging/vboxvideo/vbox_fb.c | 2 +- > > drivers/staging/vboxvideo/vbox_main.c | 8 +++--- > > drivers/staging/vboxvideo/vbox_mode.c | 2 +- > > 103 files changed, 294 insertions(+), 294 deletions(-) > > > > -- > > 2.7.4 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx