Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbdHKQCS (ORCPT ); Fri, 11 Aug 2017 12:02:18 -0400 Received: from mail-yw0-f178.google.com ([209.85.161.178]:35417 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752723AbdHKQCP (ORCPT ); Fri, 11 Aug 2017 12:02:15 -0400 Date: Fri, 11 Aug 2017 12:02:12 -0400 From: Sean Paul To: Cihangir Akturk Cc: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie , Gerd Hoffmann , David Airlie , Daniel Vetter , Laurent Pinchart , Alex Deucher , Sean Paul , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Peter Rosin , Gabriel Krisman Bertazi , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3 06/28] drm/cirrus: switch to drm_*_get(), drm_*_put() helpers Message-ID: <20170811160212.fpobovnqar3wgk7s@art_vandelay> References: <1502454794-28558-1-git-send-email-cakturk@gmail.com> <1502454794-28558-7-git-send-email-cakturk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502454794-28558-7-git-send-email-cakturk@gmail.com> User-Agent: NeoMutt/20170306-66-6ddb52-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2866 Lines: 88 On Fri, Aug 11, 2017 at 03:32:52PM +0300, Cihangir Akturk wrote: > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() > and drm_*_unreference() helpers. > > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() and should not be > used by new code. So convert all users of compatibility functions to > use the new APIs. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Cihangir Akturk Applied to drm-misc-next, thank you! Sean > --- > drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 +- > drivers/gpu/drm/cirrus/cirrus_main.c | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c > index 0f6815f..32fbfba 100644 > --- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c > +++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c > @@ -251,7 +251,7 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, > drm_fb_helper_unregister_fbi(&gfbdev->helper); > > if (gfb->obj) { > - drm_gem_object_unreference_unlocked(gfb->obj); > + drm_gem_object_put_unlocked(gfb->obj); > gfb->obj = NULL; > } > > diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c > index e7fc95f..b5f5285 100644 > --- a/drivers/gpu/drm/cirrus/cirrus_main.c > +++ b/drivers/gpu/drm/cirrus/cirrus_main.c > @@ -18,7 +18,7 @@ static void cirrus_user_framebuffer_destroy(struct drm_framebuffer *fb) > { > struct cirrus_framebuffer *cirrus_fb = to_cirrus_framebuffer(fb); > > - drm_gem_object_unreference_unlocked(cirrus_fb->obj); > + drm_gem_object_put_unlocked(cirrus_fb->obj); > drm_framebuffer_cleanup(fb); > kfree(fb); > } > @@ -67,13 +67,13 @@ cirrus_user_framebuffer_create(struct drm_device *dev, > > cirrus_fb = kzalloc(sizeof(*cirrus_fb), GFP_KERNEL); > if (!cirrus_fb) { > - drm_gem_object_unreference_unlocked(obj); > + drm_gem_object_put_unlocked(obj); > return ERR_PTR(-ENOMEM); > } > > ret = cirrus_framebuffer_init(dev, cirrus_fb, mode_cmd, obj); > if (ret) { > - drm_gem_object_unreference_unlocked(obj); > + drm_gem_object_put_unlocked(obj); > kfree(cirrus_fb); > return ERR_PTR(ret); > } > @@ -261,7 +261,7 @@ int cirrus_dumb_create(struct drm_file *file, > return ret; > > ret = drm_gem_handle_create(file, gobj, &handle); > - drm_gem_object_unreference_unlocked(gobj); > + drm_gem_object_put_unlocked(gobj); > if (ret) > return ret; > > @@ -310,7 +310,7 @@ cirrus_dumb_mmap_offset(struct drm_file *file, > bo = gem_to_cirrus_bo(obj); > *offset = cirrus_bo_mmap_offset(bo); > > - drm_gem_object_unreference_unlocked(obj); > + drm_gem_object_put_unlocked(obj); > > return 0; > } > -- > 2.7.4 > -- Sean Paul, Software Engineer, Google / Chromium OS