Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636AbdHKQEF (ORCPT ); Fri, 11 Aug 2017 12:04:05 -0400 Received: from mail-yw0-f174.google.com ([209.85.161.174]:34053 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbdHKQED (ORCPT ); Fri, 11 Aug 2017 12:04:03 -0400 Date: Fri, 11 Aug 2017 12:04:01 -0400 From: Sean Paul To: Philipp Zabel Cc: Cihangir Akturk , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers Message-ID: <20170811160401.rfee6kegnrtary74@art_vandelay> References: <1502454794-28558-1-git-send-email-cakturk@gmail.com> <1502454794-28558-14-git-send-email-cakturk@gmail.com> <1502456500.2310.14.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1502456500.2310.14.camel@pengutronix.de> User-Agent: NeoMutt/20170306-66-6ddb52-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2491 Lines: 74 On Fri, Aug 11, 2017 at 03:01:40PM +0200, Philipp Zabel wrote: > On Fri, 2017-08-11 at 15:32 +0300, Cihangir Akturk wrote: > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() > > and drm_*_unreference() helpers. > > > > drm_*_reference() and drm_*_unreference() functions are just > > compatibility alias for drm_*_get() and drm_*_put() and should not be > > used by new code. So convert all users of compatibility functions to > > use the new APIs. > > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > > > Signed-off-by: Cihangir Akturk > > --- > > ?drivers/gpu/drm/mediatek/mtk_drm_fb.c??| 4 ++-- > > ?drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- > > ?2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > index d4246c9..0d8d506 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_fb.c > > @@ -58,7 +58,7 @@ static void mtk_drm_fb_destroy(struct > > drm_framebuffer *fb) > > ? > > ? drm_framebuffer_cleanup(fb); > > ? > > - drm_gem_object_unreference_unlocked(mtk_fb->gem_obj); > > + drm_gem_object_put_unlocked(mtk_fb->gem_obj); > > ? > > ? kfree(mtk_fb); > > ?} > > @@ -160,6 +160,6 @@ struct drm_framebuffer > > *mtk_drm_mode_fb_create(struct drm_device *dev, > > ? return &mtk_fb->base; > > ? > > ?unreference: > > - drm_gem_object_unreference_unlocked(gem); > > + drm_gem_object_put_unlocked(gem); > > ? return ERR_PTR(ret); > > ?} > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > index 8ec963f..f595ac8 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > > @@ -122,7 +122,7 @@ int mtk_drm_gem_dumb_create(struct drm_file > > *file_priv, struct drm_device *dev, > > ? goto err_handle_create; > > ? > > ? /* drop reference from allocate - handle holds it now. */ > > - drm_gem_object_unreference_unlocked(&mtk_gem->base); > > + drm_gem_object_put_unlocked(&mtk_gem->base); > > ? > > ? return 0; > > ? > > Reviewed-by: Philipp Zabel Applied to drm-misc-next, thank you for the review! Sean > > regards > Philipp > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS