Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949AbdHKQGw (ORCPT ); Fri, 11 Aug 2017 12:06:52 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36981 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbdHKQGt (ORCPT ); Fri, 11 Aug 2017 12:06:49 -0400 Date: Fri, 11 Aug 2017 18:06:32 +0200 From: Daniel Vetter To: Colin King Cc: Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][drm-next] drm/i915: make structure intel_sprite_plane_funcs static Message-ID: <20170811160632.n5kmtyom4xwsk6xx@phenom.ffwll.local> Mail-Followup-To: Colin King , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170811134938.4183-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170811134938.4183-1-colin.king@canonical.com> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 43 On Fri, Aug 11, 2017 at 02:49:38PM +0100, Colin King wrote: > From: Colin Ian King > > The structure intel_sprite_plane_funcs is local to the source > and does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'intel_sprite_plane_funcs' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied, thanks. -Daniel > --- > drivers/gpu/drm/i915/intel_sprite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c > index e11f8782c9eb..524933b01483 100644 > --- a/drivers/gpu/drm/i915/intel_sprite.c > +++ b/drivers/gpu/drm/i915/intel_sprite.c > @@ -1184,7 +1184,7 @@ static bool intel_sprite_plane_format_mod_supported(struct drm_plane *plane, > unreachable(); > } > > -const struct drm_plane_funcs intel_sprite_plane_funcs = { > +static const struct drm_plane_funcs intel_sprite_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > .destroy = intel_plane_destroy, > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch