Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753500AbdHKQLN (ORCPT ); Fri, 11 Aug 2017 12:11:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59118 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbdHKQLM (ORCPT ); Fri, 11 Aug 2017 12:11:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9AE45C08EC20 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers To: Sean Paul Cc: Cihangir Akturk , devel@driverdev.osuosl.org, Michael Thayer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Peter Rosin References: <1502454794-28558-1-git-send-email-cakturk@gmail.com> <1502454794-28558-29-git-send-email-cakturk@gmail.com> <27c2b794-73b0-641f-6dcd-6cb7eeb47dff@redhat.com> <20170811160416.sdahhswjk6vcd3qr@art_vandelay> From: Hans de Goede Message-ID: <8fb1da0c-33b1-814f-3385-0cdf74193cb1@redhat.com> Date: Fri, 11 Aug 2017 18:11:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170811160416.sdahhswjk6vcd3qr@art_vandelay> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 11 Aug 2017 16:11:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4043 Lines: 120 Hi, On 11-08-17 18:04, Sean Paul wrote: > On Fri, Aug 11, 2017 at 03:26:45PM +0200, Hans de Goede wrote: >> Hi, >> >> On 11-08-17 14:33, Cihangir Akturk wrote: >>> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() >>> and drm_*_unreference() helpers. >>> >>> drm_*_reference() and drm_*_unreference() functions are just >>> compatibility alias for drm_*_get() and drm_*_put() and should not be >>> used by new code. So convert all users of compatibility functions to >>> use the new APIs. >>> >>> Generated by: scripts/coccinelle/api/drm-get-put.cocci >>> >>> Signed-off-by: Cihangir Akturk >> >> Thank you for doing this, looks good to me: >> >> Reviewed-by: Hans de Goede >> > > Applied to drm-misc-next, thank you for the review! Erm vboxvideo is in staging, does this mean all patches for it will now go through drm-misc-next despite it being in staging (*) ? Because if some patches get merged through drm-misc-next and some through Greg's staging repo that is not going to end well. Regards, Hans *) that is fine, the same is done for e.g. the media drivers afaik > > Sean > >> Regards, >> >> Hans >> >> >> >>> --- >>> drivers/staging/vboxvideo/vbox_fb.c | 2 +- >>> drivers/staging/vboxvideo/vbox_main.c | 8 ++++---- >>> drivers/staging/vboxvideo/vbox_mode.c | 2 +- >>> 3 files changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c >>> index bf66358..c157284 100644 >>> --- a/drivers/staging/vboxvideo/vbox_fb.c >>> +++ b/drivers/staging/vboxvideo/vbox_fb.c >>> @@ -343,7 +343,7 @@ void vbox_fbdev_fini(struct drm_device *dev) >>> vbox_bo_unpin(bo); >>> vbox_bo_unreserve(bo); >>> } >>> - drm_gem_object_unreference_unlocked(afb->obj); >>> + drm_gem_object_put_unlocked(afb->obj); >>> afb->obj = NULL; >>> } >>> drm_fb_helper_fini(&fbdev->helper); >>> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c >>> index d0c6ec7..80bd039 100644 >>> --- a/drivers/staging/vboxvideo/vbox_main.c >>> +++ b/drivers/staging/vboxvideo/vbox_main.c >>> @@ -40,7 +40,7 @@ static void vbox_user_framebuffer_destroy(struct drm_framebuffer *fb) >>> struct vbox_framebuffer *vbox_fb = to_vbox_framebuffer(fb); >>> if (vbox_fb->obj) >>> - drm_gem_object_unreference_unlocked(vbox_fb->obj); >>> + drm_gem_object_put_unlocked(vbox_fb->obj); >>> drm_framebuffer_cleanup(fb); >>> kfree(fb); >>> @@ -198,7 +198,7 @@ static struct drm_framebuffer *vbox_user_framebuffer_create( >>> err_free_vbox_fb: >>> kfree(vbox_fb); >>> err_unref_obj: >>> - drm_gem_object_unreference_unlocked(obj); >>> + drm_gem_object_put_unlocked(obj); >>> return ERR_PTR(ret); >>> } >>> @@ -472,7 +472,7 @@ int vbox_dumb_create(struct drm_file *file, >>> return ret; >>> ret = drm_gem_handle_create(file, gobj, &handle); >>> - drm_gem_object_unreference_unlocked(gobj); >>> + drm_gem_object_put_unlocked(gobj); >>> if (ret) >>> return ret; >>> @@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file, >>> bo = gem_to_vbox_bo(obj); >>> *offset = vbox_bo_mmap_offset(bo); >>> - drm_gem_object_unreference(obj); >>> + drm_gem_object_put(obj); >>> ret = 0; >>> out_unlock: >>> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c >>> index 996da1c..e5b6383 100644 >>> --- a/drivers/staging/vboxvideo/vbox_mode.c >>> +++ b/drivers/staging/vboxvideo/vbox_mode.c >>> @@ -812,7 +812,7 @@ static int vbox_cursor_set2(struct drm_crtc *crtc, struct drm_file *file_priv, >>> out_unreserve_bo: >>> vbox_bo_unreserve(bo); >>> out_unref_obj: >>> - drm_gem_object_unreference_unlocked(obj); >>> + drm_gem_object_put_unlocked(obj); >>> return ret; >>> } >>> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >