Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbdHKQ0T (ORCPT ); Fri, 11 Aug 2017 12:26:19 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52426 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbdHKQ0R (ORCPT ); Fri, 11 Aug 2017 12:26:17 -0400 Date: Fri, 11 Aug 2017 18:26:05 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Jork Loeser , KY Srinivasan , Simon Xiao , Haiyang Zhang , Stephen Hemminger , "luto@kernel.org" , "hpa@zytor.com" , "vkuznets@redhat.com" , "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "andy.shevchenko@gmail.com" , "tglx@linutronix.de" , "mingo@kernel.org" , "linux-tip-commits@vger.kernel.org" , "Kirill A. Shutemov" Subject: Re: [tip:x86/platform] x86/hyper-v: Use hypercall for remote TLB flush Message-ID: <20170811162605.tr4tig4av3q4fll6@hirez.programming.kicks-ass.net> References: <20170802160921.21791-8-vkuznets@redhat.com> <20170810185646.GI6524@worktop.programming.kicks-ass.net> <20170810192742.GJ6524@worktop.programming.kicks-ass.net> <20170811090336.lfznz6qzrbhiqwvi@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 33 On Fri, Aug 11, 2017 at 09:16:29AM -0700, Linus Torvalds wrote: > On Fri, Aug 11, 2017 at 2:03 AM, Peter Zijlstra wrote: > > > > I'm sure we talked about using HAVE_RCU_TABLE_FREE for x86 (and yes that > > would make it work again), but this was some years ago and I cannot > > readily find those emails. > > I think the only time we really talked about HAVE_RCU_TABLE_FREE for > x86 (at least that I was cc'd on) was not because of RCU freeing, but > because we just wanted to use the generic page table lookup code on > x86 *despite* not using RCU freeing. > > And we just ended up renaming HAVE_GENERIC_RCU_GUP as HAVE_GENERIC_GUP. > > There was only passing mention of maybe making x86 use RCU, but the > discussion was really about why the IF flag meant that x86 didn't need > to, iirc. > > I don't recall us ever discussing *really* making x86 use RCU. Google finds me this: https://lwn.net/Articles/500188/ Which includes: http://www.mail-archive.com/kvm@vger.kernel.org/msg72918.html which does as was suggested here, selects HAVE_RCU_TABLE_FREE for PARAVIRT_TLB_FLUSH. But yes, this is very much virt specific nonsense, native would never need this.