MIME-Version: 1.0
In-Reply-To: <20170811183243.GB109008@google.com>
References: <20170717195854.192139-1-mka@chromium.org> <20170811183243.GB109008@google.com>
From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Date: Fri, 11 Aug 2017 11:38:44 -0700
Message-ID: <CABVU7+vybzabzkwNPPxkzYRLLAvM8Gcu8=A3+=3LKVOSyJu8-A@mail.gmail.com>
Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Daniel Vetter <daniel@ffwll.ch>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Manasi Navare <manasi.d.navare@intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Clint Taylor <clinton.a.taylor@intel.com>,
        Grant Grundler <grundler@chromium.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        DRI mailing list <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1231
Lines: 37

On Fri, Aug 11, 2017 at 11:32 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
>
>> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
>> Use the correct table.
>>
>> The error was pointed out by this clang warning:
>>
>> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>>   [-Wunneeded-internal-declaration]
>>     static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
>>
>> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>> ---
>> Changes in v2:
>> - Added 'Fixes' tag
>> - Added Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>
> ping, it seems this patch went under the radar.

yes totally. sorry about that.

merged to dinq. Thanks for patch, review, and heads up

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br