Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753577AbdHKTIh (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 15:08:37 -0400
Received: from smtp13.smtpout.orange.fr ([80.12.242.135]:47724 "EHLO
        smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1753242AbdHKTIg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 15:08:36 -0400
X-ME-Helo: belgarion
X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy
X-ME-Date: Fri, 11 Aug 2017 21:08:34 +0200
X-ME-IP: 90.55.206.157
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Lee Jones <lee.jones@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec
References: <20170806213613.5600-1-robert.jarzmik@free.fr>
        <20170806213613.5600-7-robert.jarzmik@free.fr>
        <20170808110204.dt7bjfwkyfpbfr2w@dell>
X-URL: http://belgarath.falguerolles.org/
Date: Fri, 11 Aug 2017 21:08:22 +0200
Message-ID: <87bmnlq5w9.fsf@belgarion.home>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1397
Lines: 47

Lee Jones <lee.jones@linaro.org> writes:

> On Sun, 06 Aug 2017, Robert Jarzmik wrote:

Hi Lee,

I basically agree with all your comments, so I will only answer to your
questions.
>> +#include <linux/module.h>
>
> Why separate this?
No point, for v6.
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>
> Can you use the short version?
Yeah, sure.

>> +#ifndef __LINUX_MFD_WM97XX_H
>> +#define __LINUX_MFD_WM97XX_H
>> +
>> +struct regmap;
>> +struct wm97xx_batt_pdata;
>> +struct snd_ac97;
>
> What are you using these for?
There are for the structure just below, which doesn't need the implementation
details of these structures, but does need the definition to properly compile.

>> +struct wm97xx_platform_data {
>> +	struct snd_ac97 *ac97;
>> +	struct regmap *regmap;
>> +	struct wm97xx_batt_pdata *batt_pdata;
>> +};
This is the structure "just below" I'm speaking of.

Thanks for the review.

-- 
Robert