Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753752AbdHKTfm (ORCPT ); Fri, 11 Aug 2017 15:35:42 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:33932 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181AbdHKTfk (ORCPT ); Fri, 11 Aug 2017 15:35:40 -0400 MIME-Version: 1.0 In-Reply-To: <23a0adb0-4db0-52aa-831e-36ceca466636@canonical.com> References: <1502426037-3777-1-git-send-email-tyhicks@canonical.com> <1502426037-3777-4-git-send-email-tyhicks@canonical.com> <23a0adb0-4db0-52aa-831e-36ceca466636@canonical.com> From: Kees Cook Date: Fri, 11 Aug 2017 12:35:32 -0700 X-Google-Sender-Auth: E3J2hGK8TDDqG9n0KrjRqk2en6E Message-ID: Subject: Re: [PATCH v6 3/6] seccomp: Sysctl to configure actions that are allowed to be logged To: Tyler Hicks Cc: Andy Lutomirski , Will Drewry , Paul Moore , Eric Paris , John Crispin , Tycho Andersen , linux-audit@redhat.com, LKML , Linux API Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 20 On Fri, Aug 11, 2017 at 12:33 PM, Tyler Hicks wrote: > On 08/11/2017 02:17 PM, Kees Cook wrote: >> One thought here: should "kill" be always forced on during a write? >> This flag effectively cannot be disabled, so listing it (or not) in >> the sysctl may be confusing... > > "kill" can be silenced in the current implementation. Lets hammer out > whether or not that's the right thing to do and then we can discuss the > sysctl behavior on write. I don't personally have any concerns about an > admin being able to silence RET_KILL logs but let me know if you are > against it. Oh right, this is fine. Yeah, as long as the default is to log it (which it is) I'm fine. Thanks! -Kees -- Kees Cook Pixel Security