Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbdHLAZ7 (ORCPT ); Fri, 11 Aug 2017 20:25:59 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37305 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbdHLAZ6 (ORCPT ); Fri, 11 Aug 2017 20:25:58 -0400 Subject: Re: [PATCH v2 0/4] Update memcpy, memset etc. for M7/M8 architectures To: David Miller Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org References: <1502149972-61517-1-git-send-email-babu.moger@oracle.com> <20170810.143835.350138228946748074.davem@davemloft.net> From: Babu Moger Organization: Oracle Corporation Message-ID: <5aeffd85-7c41-0f91-54dd-d7432b274280@oracle.com> Date: Fri, 11 Aug 2017 19:25:48 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810.143835.350138228946748074.davem@davemloft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 37 David, Thanks for applying. On 8/10/2017 4:38 PM, David Miller wrote: > From: Babu Moger > Date: Mon, 7 Aug 2017 17:52:48 -0600 > >> This series of patches updates the memcpy, memset, copy_to_user, >> copy_from_user etc for SPARC M7/M8 architecture. > This doesn't build, you cannot assume the existence of "%ncc", it is a > recent addition. > > Furthermore there is no need to ever use %ncc in v9 targetted code > anyways. > > I'll fix that up, but this was a really disappointing build failure > to hit. Thank you.. > > Meanwhile, two questions: > > 1) Is this also faster on T4 as well? If it is, we can just get rid > of the T4 routines and use this on those chips as well. At the time of this work, our focus was mostly on T7 and T8. We did not test this code on T4. For T4 and other older configs we used NG4 versions. I would think it would require some changes to make it work on T4. > 2) There has been a lot of discussion and consideration put into how > a memcpy/memset routine might be really great for the local cpu > but overall pessimize performance for other cpus either locally > on the same core (contention for physical resources such as > ports to the store buffer and/or L3 cache) or on other cores. > > Has any such study been done into these issues wrt. this new code? No, we have not done this kind of study.