Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752048AbdHLDHt (ORCPT ); Fri, 11 Aug 2017 23:07:49 -0400 Received: from hermes.aosc.io ([199.195.250.187]:41092 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbdHLDHr (ORCPT ); Fri, 11 Aug 2017 23:07:47 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 12 Aug 2017 11:07:42 +0800 From: icenowy@aosc.io To: Maxime Ripard Cc: Priit Laes , Mark Rutland , devicetree@vger.kernel.org, Jonathan Liu , Michael Turquette , linux-sunxi@googlegroups.com, Stephen Boyd , Russell King , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Philipp Zabel , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 1/6] clk: sunxi-ng: div: Add support for fixed post-divider In-Reply-To: <20170717085235.i7pwwql5dgmnf6kk@flea> References: <946794e97ae2c36cd67c272099e8236a589efc28.1500043741.git-series.plaes@plaes.org> <20170717085235.i7pwwql5dgmnf6kk@flea> Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1480 Lines: 44 在 2017-07-17 16:52，Maxime Ripard 写道： > On Fri, Jul 14, 2017 at 05:49:23PM +0300, Priit Laes wrote: >> SATA clock on sun4i/sun7i is of type (parent) / M / 6 where >> 6 is fixed post-divider. >> >> Signed-off-by: Priit Laes >> --- >> drivers/clk/sunxi-ng/ccu_div.c | 15 +++++++++++++-- >> drivers/clk/sunxi-ng/ccu_div.h | 3 ++- >> 2 files changed, 15 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/clk/sunxi-ng/ccu_div.c >> b/drivers/clk/sunxi-ng/ccu_div.c >> index c0e5c10..744502a 100644 >> --- a/drivers/clk/sunxi-ng/ccu_div.c >> +++ b/drivers/clk/sunxi-ng/ccu_div.c >> @@ -21,6 +21,9 @@ static unsigned long ccu_div_round_rate(struct >> ccu_mux_internal *mux, >> { >> struct ccu_div *cd = data; >> >> + if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV) >> + rate *= cd->fixed_post_div; >> + >> return divider_round_rate_parent(&cd->common.hw, parent, >> rate, parent_rate, >> cd->div.table, cd->div.width, > > > You still haven't addressed the biggest issue with this patch, see: > https://patchwork.kernel.org/patch/9825565/ I think he has already did the changes suggested in the review. (P.S. during developing R40 CCU driver I found that pll-periph0-sata also needs this patch, so I'm rechecking it) > > Maxime > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel