Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750998AbdHLHoy (ORCPT ); Sat, 12 Aug 2017 03:44:54 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56760 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbdHLHox (ORCPT ); Sat, 12 Aug 2017 03:44:53 -0400 Date: Sat, 12 Aug 2017 00:44:51 -0700 From: Christoph Hellwig To: Julia Lawall Cc: linux-scsi@vger.kernel.org, bhumirks@gmail.com, kernel-janitors@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/6] constify pci_error_handlers structures Message-ID: <20170812074451.GA3589@infradead.org> References: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 464 Lines: 10 On Sat, Aug 12, 2017 at 07:44:28AM +0200, Julia Lawall wrote: > These pci_error_handlers structures are only stored in the err_handler > field of a pci_driver structure, and this field is declared as const. Thus > the pci_error_handlers structures can be const too. > > Done with the help of Coccinelle. If you're doing a scripted conversion of the pci_error_handlers structured I'd much rather see that structure killed off and folded into the pci_driver one.