Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750995AbdHLIAf (ORCPT <rfc822;w@1wt.eu>);
        Sat, 12 Aug 2017 04:00:35 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:39103
        "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750762AbdHLIAe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 12 Aug 2017 04:00:34 -0400
X-IronPort-AV: E=Sophos;i="5.41,362,1498514400"; 
   d="scan'208";a="234249827"
Date: Sat, 12 Aug 2017 10:00:27 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Christoph Hellwig <hch@infradead.org>
cc: linux-scsi@vger.kernel.org, bhumirks@gmail.com,
        kernel-janitors@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 0/6] constify pci_error_handlers structures
In-Reply-To: <20170812075616.GA14976@infradead.org>
Message-ID: <alpine.DEB.2.20.1708120959540.2001@hadrien>
References: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr> <20170812074451.GA3589@infradead.org> <alpine.DEB.2.20.1708120946590.2001@hadrien> <20170812075616.GA14976@infradead.org>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 682
Lines: 25



On Sat, 12 Aug 2017, Christoph Hellwig wrote:

> On Sat, Aug 12, 2017 at 09:52:28AM +0200, Julia Lawall wrote:
> > OK, sure.  So to be precise, you want the fields error_detected,
> > mmio_enabled, etc to be added as new fields to the pci_driver structure?
>
> Yes.
>
> > They both have a resume field, though.  What should the pci_error_handlers
> > resume function be renamed to?  Would resume_after_error be too much?
>
> error_resume maybe?

OK

>
> FYI, I already killed it for the PCIe port drivers a while ago:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/aer&id=c5dc3c69f17a7e77359f10c342d1816390bc8846

Thanks for the pointer.

julia