Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbdHLL0J (ORCPT ); Sat, 12 Aug 2017 07:26:09 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:52396 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbdHLL0I (ORCPT ); Sat, 12 Aug 2017 07:26:08 -0400 Date: Sat, 12 Aug 2017 12:26:03 +0100 From: Mark Rutland To: Tycho Andersen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-hardening@lists.openwall.com, Marco Benatto , Juerg Haefliger , Juerg Haefliger Subject: Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Message-ID: <20170812112603.GB16374@remoulade> References: <20170809200755.11234-1-tycho@docker.com> <20170809200755.11234-5-tycho@docker.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170809200755.11234-5-tycho@docker.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 42 On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > From: Juerg Haefliger > > Add a hook for flushing a single TLB entry on arm64. > > Signed-off-by: Juerg Haefliger > Tested-by: Tycho Andersen > --- > arch/arm64/include/asm/tlbflush.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h > index af1c76981911..8e0c49105d3e 100644 > --- a/arch/arm64/include/asm/tlbflush.h > +++ b/arch/arm64/include/asm/tlbflush.h > @@ -184,6 +184,14 @@ static inline void flush_tlb_kernel_range(unsigned long start, unsigned long end > isb(); > } > > +static inline void __flush_tlb_one(unsigned long addr) > +{ > + dsb(ishst); > + __tlbi(vaae1is, addr >> 12); > + dsb(ish); > + isb(); > +} Is this going to be called by generic code? It would be nice if we could drop 'kernel' into the name, to make it clear this is intended to affect the kernel mappings, which have different maintenance requirements to user mappings. We should be able to implement this more simply as: flush_tlb_kernel_page(unsigned long addr) { flush_tlb_kernel_range(addr, addr + PAGE_SIZE); } Thanks, Mark.