Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbdHLLv1 (ORCPT ); Sat, 12 Aug 2017 07:51:27 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:56629 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbdHLLv0 (ORCPT ); Sat, 12 Aug 2017 07:51:26 -0400 X-IronPort-AV: E=Sophos;i="5.41,363,1498514400"; d="scan'208";a="234259034" Date: Sat, 12 Aug 2017 13:51:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Christoph Hellwig cc: linux-scsi@vger.kernel.org, bhumirks@gmail.com, kernel-janitors@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/6] constify pci_error_handlers structures In-Reply-To: <20170812075616.GA14976@infradead.org> Message-ID: References: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr> <20170812074451.GA3589@infradead.org> <20170812075616.GA14976@infradead.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 461 Lines: 10 Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers structure is defined in one file and used in another file. The structure definition references various functions that are static in the same file. Should I try to move those functions to the file containing the pci_driver structure? Or leave the functions where they are and remove the static annotation? thanks, julia