From: Dave Carroll <david.carroll@microsemi.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
        dl-esc-Aacraid Linux Driver <aacraid@microsemi.com>
CC: "bhumirks@gmail.com" <bhumirks@gmail.com>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/6] scsi: aacraid: constify pci_error_handlers
 structures
Thread-Topic: [PATCH 3/6] scsi: aacraid: constify pci_error_handlers
 structures
Thread-Index: AQHTEzGp4VpMuuEMNk2MbLU5Ya6IPKKBkbAQ
Date: Sun, 13 Aug 2017 02:32:23 +0000
Message-ID: <423FD6710FB8FB4F8728F93591889F9A5B3E16C1@avsrvexchmbx2.microsemi.net>
References: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr>
 <1502516674-8918-4-git-send-email-Julia.Lawall@lip6.fr>
In-Reply-To: <1502516674-8918-4-git-send-email-Julia.Lawall@lip6.fr>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2017 02:32:51.3159
 (UTC)
X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.20];Helo=[avsrvexchhts2.microsemi.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0201MB0933
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7D2X6ZV010428
Content-Length: 1085
Lines: 28

> 
> These pci_error_handlers structures are only stored in the err_handler field of a
> pci_driver structure, and this field is declared as const.  Thus the
> pci_error_handlers structures can be const too.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/scsi/aacraid/linit.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index
> a8dedc3..2b978d8 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -2070,7 +2070,7 @@ static void aac_pci_resume(struct pci_dev *pdev)
>         dev_err(&pdev->dev, "aacraid: PCI error - resume\n");  }
> 
> -static struct pci_error_handlers aac_pci_err_handler = {
> +static const struct pci_error_handlers aac_pci_err_handler = {
>         .error_detected         = aac_pci_error_detected,
>         .mmio_enabled           = aac_pci_mmio_enabled,
>         .slot_reset             = aac_pci_slot_reset,

Acked-by: Dave Carroll <david.carroll@microsemi.com>