Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbdHMH4w convert rfc822-to-8bit (ORCPT ); Sun, 13 Aug 2017 03:56:52 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:53419 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbdHMH4v (ORCPT ); Sun, 13 Aug 2017 03:56:51 -0400 Date: Sun, 13 Aug 2017 09:56:48 +0200 From: Boris Brezillon To: Pan Bian Cc: Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: mtd: nand: use dma_mapping_error to check map errors Message-ID: <20170813095648.4a2a2764@bbrezillon> In-Reply-To: <1502202942-23984-1-git-send-email-bianpan2016@163.com> References: <1502202942-23984-1-git-send-email-bianpan2016@163.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 30 Le Tue, 8 Aug 2017 22:35:42 +0800, Pan Bian a écrit : > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function flctl_dma_fifo0_transfer(), its > return value is checked against NULL, which could result in failures. Applied, thanks. Boris > > Signed-off-by: Pan Bian > --- > drivers/mtd/nand/sh_flctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index 891ac7b..2404d66 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -411,7 +411,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf, > > dma_addr = dma_map_single(chan->device->dev, buf, len, dir); > > - if (dma_addr) > + if (!dma_mapping_error(chan->device->dev, dma_addr)) > desc = dmaengine_prep_slave_single(chan, dma_addr, len, > tr_dir, DMA_PREP_INTERRUPT | DMA_CTRL_ACK); >