Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbdHMK1j (ORCPT ); Sun, 13 Aug 2017 06:27:39 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59935 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbdHMK1h (ORCPT ); Sun, 13 Aug 2017 06:27:37 -0400 Date: Sun, 13 Aug 2017 03:27:35 -0700 From: Christoph Hellwig To: Long Li Cc: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Long Li Subject: Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Message-ID: <20170813102735.GI17287@infradead.org> References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 16 Hi Long, a few meta-comments: first the split into lots of tiny lists makes the series really hard to read, I'd split it into just a few: Patch 1: add the protocol constants Patch 2-n: core cifs modifcation required to implement SMBD Patch n+1: add the actual SMBD code Patch n+2..m: write up the core CIFS code to use it. stcond a lot of the code doesn't seem to follow the usual Linux style. It might be a good idea to run it through scripts/checkpach.pl and at least fix the errors it generates. The warnings are much more opinioned so feel free to ignore them if they sound odd for now.