Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752435AbdHMLri (ORCPT ); Sun, 13 Aug 2017 07:47:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbdHMLrh (ORCPT ); Sun, 13 Aug 2017 07:47:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 31A9327B9A9 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH] ACPI / PMIC: constify platform_device_id To: Arvind Yadav , rjw@rjwysocki.net, lenb@kernel.org, andriy.shevchenko@linux.intel.com Cc: linux-kernel@vger.kernel.org References: <4b568fafd30b850348ea390fcd0cb1dae2830c2b.1502623056.git.arvind.yadav.cs@gmail.com> From: Hans de Goede Message-ID: <34db5305-8ca5-7f2b-68db-88f8cd349757@redhat.com> Date: Sun, 13 Aug 2017 13:47:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4b568fafd30b850348ea390fcd0cb1dae2830c2b.1502623056.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 13 Aug 2017 11:47:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 38 Hi, On 13-08-17 13:23, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav Good catch: Acked-by: Hans de Goede Regards, Hans > --- > drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c > index 85636d7..813b829 100644 > --- a/drivers/acpi/pmic/intel_pmic_chtwc.c > +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c > @@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev) > &intel_cht_wc_pmic_opregion_data); > } > > -static struct platform_device_id cht_wc_opregion_id_table[] = { > +static const struct platform_device_id cht_wc_opregion_id_table[] = { > { .name = "cht_wcove_region" }, > {}, > }; >