Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbdHMOhx (ORCPT ); Sun, 13 Aug 2017 10:37:53 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:55320 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbdHMOhu (ORCPT ); Sun, 13 Aug 2017 10:37:50 -0400 Date: Sun, 13 Aug 2017 07:37:50 -0700 From: Christoph Hellwig To: Julia Lawall Cc: Christoph Hellwig , linux-scsi@vger.kernel.org, bhumirks@gmail.com, kernel-janitors@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/6] constify pci_error_handlers structures Message-ID: <20170813143750.GB407@infradead.org> References: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr> <20170812074451.GA3589@infradead.org> <20170812075616.GA14976@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 10 On Sat, Aug 12, 2017 at 01:51:21PM +0200, Julia Lawall wrote: > Another issue arises in the files drivers/infiniband/hw/hfi1/pcie.c and > drivers/infiniband/hw/qib/qib_pcie.c, where the pci_error_handlers > structure is defined in one file and used in another file. The structure > definition references various functions that are static in the same file. > Should I try to move those functions to the file containing the pci_driver > structure? Or leave the functions where they are and remove the static > annotation? I'd just leave them as-is and remove the static for now.