Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751692AbdHMQYI (ORCPT ); Sun, 13 Aug 2017 12:24:08 -0400 Received: from h2.hallyn.com ([78.46.35.8]:51174 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdHMQYH (ORCPT ); Sun, 13 Aug 2017 12:24:07 -0400 Date: Sun, 13 Aug 2017 11:24:14 -0500 From: "Serge E. Hallyn" To: "Serge E. Hallyn" Cc: SF Markus Elfring , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Alexey Dobriyan , Daniel Jurgens , Eric Paris , James Morris , Junil Lee , Paul Moore , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/4] selinux: Delete eight unnecessary variable assignments Message-ID: <20170813162414.GC4515@mail.hallyn.com> References: <05edc763-dddd-fe48-b98c-21e4ad5463a3@users.sourceforge.net> <20170813162233.GB4515@mail.hallyn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170813162233.GB4515@mail.hallyn.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 17 Quoting Serge E. Hallyn (serge@hallyn.com): > Quoting SF Markus Elfring (elfring@users.sourceforge.net): > > From: Markus Elfring > > Date: Sun, 13 Aug 2017 14:17:48 +0200 > > > > One local variable was reset to zero at the end of these functions. > > This value will also be set by a previous call of a function if it was > > executed successfully. Thus omit an extra assignment there. > > > > Signed-off-by: Markus Elfring > > Acked-by: Serge Hallyn BTW this does add a burden to the maintainers as it makes the code a bit more fragile in the face of future changes. So my ack means it looks ok, but if the maintainers don't want to take it I absolutely understand.