Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbdHNBSk (ORCPT ); Sun, 13 Aug 2017 21:18:40 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:38039 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbdHNBSj (ORCPT ); Sun, 13 Aug 2017 21:18:39 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: guodong.xu@linaro.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <70c03026d3d8ca84a2ead72173adde28> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Cc: shawn.lin@rock-chips.com, guodong.xu@linaro.org Subject: Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init To: Li Wei , ulf.hansson@linaro.org, jh80.chung@samsung.com, hkallweit1@gmail.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170811080624.42173-1-liwei213@huawei.com> From: Shawn Lin Message-ID: Date: Mon, 14 Aug 2017 09:18:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170811080624.42173-1-liwei213@huawei.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 527 Lines: 19 Trim cc On 2017/8/11 16:06, Li Wei wrote: > This commit modifies dw_mci_probe(), it moves reset assertion before > drv_data->init(host) > > Some driver needs to access controller registers in its .init() ops. So, > in order to make such access safe, we should do controller reset before > .init() being called. > LGTM Reviewed-by: Shawn Lin > Signed-off-by: Wei Li > Signed-off-by: Guodong Xu > Signed-off-by: Chen Jun > ---