Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbdHNCXc (ORCPT ); Sun, 13 Aug 2017 22:23:32 -0400 Received: from mail-vk0-f48.google.com ([209.85.213.48]:33444 "EHLO mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbdHNCXa (ORCPT ); Sun, 13 Aug 2017 22:23:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170804201921.156890-1-terrelln@fb.com> <20170804201921.156890-5-terrelln@fb.com> From: Phillip Lougher Date: Mon, 14 Aug 2017 03:23:28 +0100 Message-ID: Subject: Re: [PATCH v4 4/5] squashfs: Add zstd support To: Geert Uytterhoeven Cc: Nick Terrell , "Austin S . Hemmelgarn" , Herbert Xu , kernel-team@fb.com, Chris Mason , Yann Collet , Adam Borowski , David Sterba , SquashFS developers , linux-btrfs , "linux-kernel@vger.kernel.org" , Phillip Lougher , Sean Purcell Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1674 Lines: 52 On Sun, Aug 13, 2017 at 9:31 AM, Geert Uytterhoeven wrote: > On Fri, Aug 4, 2017 at 10:19 PM, Nick Terrell wrote: >> --- a/fs/squashfs/decompressor.c >> +++ b/fs/squashfs/decompressor.c >> @@ -65,6 +65,12 @@ static const struct squashfs_decompressor squashfs_zlib_comp_ops = { >> }; >> #endif >> >> +#ifndef CONFIG_SQUASHFS_ZSTD >> +static const struct squashfs_decompressor squashfs_zstd_comp_ops = { >> + NULL, NULL, NULL, NULL, ZSTD_COMPRESSION, "zstd", 0 > > Can you please use designated initializers? I prefer it as it is. It matches the coding style that I used in the rest of that file to declare the "unsupported" compressor entries (if this patch uses a different style it would look odd). There's no pointers to functions being assigned here, and it makes it a short and concise one-line. Phillip > >> +}; >> +#endif >> + >> static const struct squashfs_decompressor squashfs_unknown_comp_ops = { >> NULL, NULL, NULL, NULL, 0, "unknown", 0 >> ; > >> +const struct squashfs_decompressor squashfs_zstd_comp_ops = { >> + .init = zstd_init, >> + .free = zstd_free, >> + .decompress = zstd_uncompress, >> + .id = ZSTD_COMPRESSION, >> + .name = "zstd", >> + .supported = 1 >> +}; > > ... like you did here. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds