Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403AbdHNGfN (ORCPT ); Mon, 14 Aug 2017 02:35:13 -0400 Received: from outboundhk.mxmail.xiaomi.com ([207.226.244.123]:9084 "EHLO xiaomi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750936AbdHNGfM (ORCPT ); Mon, 14 Aug 2017 02:35:12 -0400 From: Hui Zhu To: , , , , CC: , Hui Zhu Subject: [PATCH] zsmalloc: zs_page_migrate: schedule free_work if zspage is ZS_EMPTY Date: Mon, 14 Aug 2017 14:34:46 +0800 Message-ID: <1502692486-27519-1-git-send-email-zhuhui@xiaomi.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.235.171.194] X-ClientProxiedBy: CNCAS3.mioffice.cn (10.237.8.133) To cnbox6.mioffice.cn (10.237.8.146) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 38 After commit e2846124f9a2 ("zsmalloc: zs_page_migrate: skip unnecessary loops but not return -EBUSY if zspage is not inuse") zs_page_migrate can handle the ZS_EMPTY zspage. But it will affect the free_work free the zspage. That will make this ZS_EMPTY zspage stay in system until another zspage wake up free_work. Make this patch let zs_page_migrate wake up free_work if need. Fixes: e2846124f9a2 ("zsmalloc: zs_page_migrate: skip unnecessary loops but not return -EBUSY if zspage is not inuse") Signed-off-by: Hui Zhu --- mm/zsmalloc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 62457eb..48ce043 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -2035,8 +2035,14 @@ int zs_page_migrate(struct address_space *mapping, struct page *newpage, * Page migration is done so let's putback isolated zspage to * the list if @page is final isolated subpage in the zspage. */ - if (!is_zspage_isolated(zspage)) - putback_zspage(class, zspage); + if (!is_zspage_isolated(zspage)) { + /* + * The page and class is locked, we cannot free zspage + * immediately so let's defer. + */ + if (putback_zspage(class, zspage) == ZS_EMPTY) + schedule_work(&pool->free_work); + } reset_page(page); put_page(page); -- 1.9.1