Date: Mon, 14 Aug 2017 00:14:34 -0700
From: Felix Manlunas <felix.manlunas@cavium.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Derek Chickles <derek.chickles@caviumnetworks.com>,
        Satanand Burla <satananda.burla@caviumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] liquidio: fix duplicated code for different branches
Message-ID: <20170814071434.GA1046@felix-thinkpad.cavium.com>
References: <20170813013855.GA6686@embeddedgus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170813013855.GA6686@embeddedgus>
User-Agent: Mutt/1.6.1 (2016-04-27)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 07:14:46.5919 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3174
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1478
Lines: 48

On Sat, Aug 12, 2017 at 08:38:55PM -0500, Gustavo A. R. Silva wrote:
> Refactor code in order to avoid identical code for different branches.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> This code was tested by compilation only.
> 
>  drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> index b78e296..4f65c08 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
> @@ -578,23 +578,18 @@ static int lio_set_phys_id(struct net_device *netdev,
>  		break;
>  
>  	case ETHTOOL_ID_ON:
> -		if (oct->chip_id == OCTEON_CN66XX) {
> +		if (oct->chip_id == OCTEON_CN66XX)
>  			octnet_gpio_access(netdev, VITESSE_PHY_GPIO_CFG,
>  					   VITESSE_PHY_GPIO_HIGH);
> -
> -		} else if (oct->chip_id == OCTEON_CN68XX) {
> -			return -EINVAL;
> -		} else {
> +		else
>  			return -EINVAL;
> -		}
> +
>  		break;
>  
>  	case ETHTOOL_ID_OFF:
>  		if (oct->chip_id == OCTEON_CN66XX)
>  			octnet_gpio_access(netdev, VITESSE_PHY_GPIO_CFG,
>  					   VITESSE_PHY_GPIO_LOW);
> -		else if (oct->chip_id == OCTEON_CN68XX)
> -			return -EINVAL;
>  		else
>  			return -EINVAL;
>  
> -- 
> 2.5.0
> 

Acked-by: Felix Manlunas <felix.manlunas@cavium.com>