Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdHNH1A (ORCPT ); Mon, 14 Aug 2017 03:27:00 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:40051 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbdHNH07 (ORCPT ); Mon, 14 Aug 2017 03:26:59 -0400 Message-ID: <1502695614.2287.4.camel@pengutronix.de> Subject: Re: [PATCH] [media] media: imx: use setup_timer From: Philipp Zabel To: Cihangir Akturk Cc: Steve Longerbeam , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 14 Aug 2017 09:26:54 +0200 In-Reply-To: <1502649578-16754-1-git-send-email-cakturk@gmail.com> References: <1502649578-16754-1-git-send-email-cakturk@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2019 Lines: 54 On Sun, 2017-08-13 at 21:39 +0300, Cihangir Akturk wrote: > Use setup_timer function instead of initializing timer with the > function and data fields. > > Generated by: scripts/coccinelle/api/setup_timer.cocci. > > Signed-off-by: Cihangir Akturk > --- >  drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++--- >  drivers/staging/media/imx/imx-media-csi.c   | 5 ++--- >  2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c > b/drivers/staging/media/imx/imx-ic-prpencvf.c > index ed363fe..65f5729 100644 > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c > @@ -1278,9 +1278,8 @@ static int prp_init(struct imx_ic_priv > *ic_priv) >   priv->ic_priv = ic_priv; >   >   spin_lock_init(&priv->irqlock); > - init_timer(&priv->eof_timeout_timer); > - priv->eof_timeout_timer.data = (unsigned long)priv; > - priv->eof_timeout_timer.function = prp_eof_timeout; > + setup_timer(&priv->eof_timeout_timer, prp_eof_timeout, > +     (unsigned long)priv); >   >   priv->vdev = imx_media_capture_device_init(&ic_priv->sd, >      PRPENCVF_SRC_PAD) > ; > diff --git a/drivers/staging/media/imx/imx-media-csi.c > b/drivers/staging/media/imx/imx-media-csi.c > index a2d2669..8fef5f1 100644 > --- a/drivers/staging/media/imx/imx-media-csi.c > +++ b/drivers/staging/media/imx/imx-media-csi.c > @@ -1731,9 +1731,8 @@ static int imx_csi_probe(struct platform_device > *pdev) >   priv->csi_id = pdata->csi; >   priv->smfc_id = (priv->csi_id == 0) ? 0 : 2; >   > - init_timer(&priv->eof_timeout_timer); > - priv->eof_timeout_timer.data = (unsigned long)priv; > - priv->eof_timeout_timer.function = csi_idmac_eof_timeout; > + setup_timer(&priv->eof_timeout_timer, csi_idmac_eof_timeout, > +     (unsigned long)priv); >   spin_lock_init(&priv->irqlock); >   >   v4l2_subdev_init(&priv->sd, &csi_subdev_ops); Reviewed-by: Philipp Zabel regards Philipp