Date: Mon, 14 Aug 2017 10:58:26 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sean Paul <seanpaul@chromium.org>, Cihangir Akturk <cakturk@gmail.com>,
        devel@driverdev.osuosl.org, Michael Thayer <michael.thayer@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Daniel Vetter <daniel.vetter@ffwll.ch>, Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(),
 drm_*_put() helpers
Message-ID: <20170814085826.uja2poh7yjwzb2yq@phenom.ffwll.local>
Mail-Followup-To: Hans de Goede <hdegoede@redhat.com>,
        Sean Paul <seanpaul@chromium.org>,
        Cihangir Akturk <cakturk@gmail.com>, devel@driverdev.osuosl.org,
        Michael Thayer <michael.thayer@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Peter Rosin <peda@axentia.se>
References: <1502454794-28558-1-git-send-email-cakturk@gmail.com>
 <1502454794-28558-29-git-send-email-cakturk@gmail.com>
 <27c2b794-73b0-641f-6dcd-6cb7eeb47dff@redhat.com>
 <20170811160416.sdahhswjk6vcd3qr@art_vandelay>
 <8fb1da0c-33b1-814f-3385-0cdf74193cb1@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8fb1da0c-33b1-814f-3385-0cdf74193cb1@redhat.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1664
Lines: 45

On Fri, Aug 11, 2017 at 06:11:08PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 11-08-17 18:04, Sean Paul wrote:
> > On Fri, Aug 11, 2017 at 03:26:45PM +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 11-08-17 14:33, Cihangir Akturk wrote:
> > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> > > > and drm_*_unreference() helpers.
> > > > 
> > > > drm_*_reference() and drm_*_unreference() functions are just
> > > > compatibility alias for drm_*_get() and drm_*_put() and should not be
> > > > used by new code. So convert all users of compatibility functions to
> > > > use the new APIs.
> > > > 
> > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> > > > 
> > > > Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> > > 
> > > Thank you for doing this, looks good to me:
> > > 
> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > > 
> > 
> > Applied to drm-misc-next, thank you for the review!
> 
> Erm vboxvideo is in staging, does this mean all patches for
> it will now go through drm-misc-next despite it being in
> staging (*) ?  Because if some patches get merged through
> drm-misc-next and some through Greg's staging repo that
> is not going to end well.

-staging doesn't work for drm. And yes this patch needs to go in through
drm-misc I think (I don't want to be at Greg's mercy for merging cleanups,
same way we don't wait for driver maintainers if they don't merge the
patch in a timely fashion).

I'd say if no one is actually working on vbox cleanup (i.e. porting to
atomic) we'll throw it out next cycle again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch