Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbdHNKFs (ORCPT ); Mon, 14 Aug 2017 06:05:48 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:15281 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752195AbdHNKFq (ORCPT ); Mon, 14 Aug 2017 06:05:46 -0400 Message-ID: <1502705139.930.78.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding From: Jun Gao To: Matthias Brugger CC: Wolfram Sang , , , , , , Date: Mon, 14 Aug 2017 18:05:39 +0800 In-Reply-To: <3384d424-827a-0a4b-d1d6-7d361d8c8391@gmail.com> References: <1502264631-12572-1-git-send-email-jun.gao@mediatek.com> <1502264631-12572-2-git-send-email-jun.gao@mediatek.com> <3384d424-827a-0a4b-d1d6-7d361d8c8391@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2028 Lines: 48 On Mon, 2017-08-14 at 11:36 +0200, Matthias Brugger wrote: > > On 08/09/2017 09:43 AM, Jun Gao wrote: > > From: Jun Gao > > > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > > controller, MT7622 limit message size to 255, and not support > > 4GB DMA mode. > > > > Signed-off-by: Jun Gao > > --- > > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > index bd5a7be..ff9ac61 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > > > Required properties: > > - compatible: value should be either of the following. > > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > > + "mediatek,mt6577-i2c": for Mediatek MT6577 > > + "mediatek,mt6589-i2c": for Mediatek MT6589 > > + "mediatek,mt7622-i2c": for Mediatek MT7622 > > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > > + "mediatek,mt8173-i2c": for Mediatek MT8173 > > - reg: physical base address of the controller and dma base, length of memory > > mapped region. > > - interrupts: interrupt number to the cpu. > > > > In the next series, could you please make sure not to change the indentation. > > Thanks a lot, > Matthias Please review [PATCH v2 1/2], I will not change the indentation any more. Thanks! Jun