Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752965AbdHNK5y (ORCPT ); Mon, 14 Aug 2017 06:57:54 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35293 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbdHNK5w (ORCPT ); Mon, 14 Aug 2017 06:57:52 -0400 Date: Mon, 14 Aug 2017 12:57:48 +0200 From: Ingo Molnar To: Byungchul Park Cc: peterz@infradead.org, tglx@linutronix.de, walken@google.com, boqun.feng@gmail.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, npiggin@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature Message-ID: <20170814105748.zbnkjbgwbaxftu43@gmail.com> References: <1502089981-21272-1-git-send-email-byungchul.park@lge.com> <20170810111019.n376bsm6h4de2jvi@gmail.com> <20170810114504.GD20323@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170810114504.GD20323@X58A-UD3R> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 37 * Byungchul Park wrote: > On Thu, Aug 10, 2017 at 01:10:19PM +0200, Ingo Molnar wrote: > > > > * Byungchul Park wrote: > > > > > Change from v7 > > > - rebase on latest tip/sched/core (Jul 26 2017) > > > - apply peterz's suggestions > > > - simplify code of crossrelease_{hist/soft/hard}_{start/end} > > > - exclude a patch avoiding redundant links > > > - exclude a patch already applied onto the base > > > > Ok, it's looking pretty good here now, there's one thing I'd like you to change, > > please remove all the new Kconfig dependencies: > > > > CONFIG_LOCKDEP_CROSSRELEASE=y > > CONFIG_LOCKDEP_COMPLETE=y > > > > and make it all part of PROVE_LOCKING, like most of the other lock debugging bits. > > OK. I will remove them. What about CONFIG_LOCKDEP_PAGELOCK? Should I also > remove it? So I'd only remove the forced _configurability_ - we can still keep those variables just fine. They modularize the code and they might be useful later on if for some reason there's some really bad performance aspect that would make one of these lockdep components to be configured out by default. Just make the user interface sane - i.e. only one switch needed to enable full lockdep. Internal modularization is fine, as long as it's not ugly and the user is not burdened with it. Thanks, Ingo