Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbdHNMqH convert rfc822-to-8bit (ORCPT ); Mon, 14 Aug 2017 08:46:07 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:48268 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbdHNMqD (ORCPT ); Mon, 14 Aug 2017 08:46:03 -0400 From: Aleksandar Markovic To: Alexandre Belloni CC: "linux-mips@linux-mips.org" , Goran Ferenc , Alessandro Zummo , Bo Hu , "David S. Miller" , Douglas Leung , Greg Kroah-Hartman , James Hogan , Jin Qian , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "Mauro Carvalho Chehab" , Paul Burton , "Petar Jovanovic" , Raghu Gandham , Miodrag Dinic , Aleksandar Markovic Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Thread-Topic: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Thread-Index: AQHTAkJJY8Ad4A9jZUeb/S2sL6gv9qJ+oPYAgAFSioCAA/qWYw== Date: Mon, 14 Aug 2017 12:45:55 +0000 Message-ID: References: <1500656111-9520-1-git-send-email-aleksandar.markovic@rt-rk.com> <1500656111-9520-3-git-send-email-aleksandar.markovic@rt-rk.com>,<20170810203430.zgtxvi7uaqmg4dzr@piout.net>,<232DDC0A2B605E4F9E85F6904417885F015D937238@BADAG02.ba.imgtec.org> In-Reply-To: <232DDC0A2B605E4F9E85F6904417885F015D937238@BADAG02.ba.imgtec.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [82.117.201.26] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2519 Lines: 70 Hello, Alexandre, In addition, if you, and everybody else, don't object, I plan to change the title of this patch form: "MIPS: ranchu: Add Goldfish RTC driver" to "rtc: Add Goldfish RTC driver", to be more consistent with all commit messages for this kernel source directory. Regards, Aleksandar ________________________________________ From: Miodrag Dinic Sent: Friday, August 11, 2017 9:46 AM To: Alexandre Belloni; Aleksandar Markovic Cc: linux-mips@linux-mips.org; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Hi Alexandre, we have this sorted & plan to submit version 4 of this series next week. Thank you. Kind regards, Miodrag ________________________________________ From: Alexandre Belloni [alexandre.belloni@free-electrons.com] Sent: Thursday, August 10, 2017 10:34 PM To: Aleksandar Markovic Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Hi, On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote: > From: Miodrag Dinic > > Add device driver for a virtual Goldfish RTC clock. > > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are > set. The compatible string used by OS for binding the driver is > defined as "google,goldfish-rtc". > > Signed-off-by: Miodrag Dinic > Signed-off-by: Goran Ferenc > Signed-off-by: Aleksandar Markovic > --- > MAINTAINERS | 1 + > drivers/rtc/Kconfig | 8 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 243 insertions(+) > create mode 100644 drivers/rtc/rtc-goldfish.c > Do you mind fixing the remaining checkpatch --strict issues, the two kbuild errors and the warning reported by Julia? Thanks! -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com