Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753339AbdHNNNv (ORCPT ); Mon, 14 Aug 2017 09:13:51 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:51087 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbdHNNNu (ORCPT ); Mon, 14 Aug 2017 09:13:50 -0400 Date: Mon, 14 Aug 2017 15:13:48 +0200 From: Alexandre Belloni To: Aleksandar Markovic Cc: "linux-mips@linux-mips.org" , Goran Ferenc , Alessandro Zummo , Bo Hu , "David S. Miller" , Douglas Leung , Greg Kroah-Hartman , James Hogan , Jin Qian , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" , Mauro Carvalho Chehab , Paul Burton , Petar Jovanovic , Raghu Gandham , Miodrag Dinic , Aleksandar Markovic Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Message-ID: <20170814131348.ztdea5kzgiflzlgk@piout.net> References: <1500656111-9520-1-git-send-email-aleksandar.markovic@rt-rk.com> <1500656111-9520-3-git-send-email-aleksandar.markovic@rt-rk.com> <20170810203430.zgtxvi7uaqmg4dzr@piout.net> <232DDC0A2B605E4F9E85F6904417885F015D937238@BADAG02.ba.imgtec.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2868 Lines: 79 On 14/08/2017 at 12:45:55 +0000, Aleksandar Markovic wrote: > Hello, Alexandre, > > In addition, if you, and everybody else, don't object, I plan to change the title of this patch form: > > "MIPS: ranchu: Add Goldfish RTC driver" > > to > > "rtc: Add Goldfish RTC driver", > > to be more consistent with all commit messages for this kernel source directory. > Yes please, I would have changed it anyway. > Regards, > Aleksandar > > ________________________________________ > From: Miodrag Dinic > Sent: Friday, August 11, 2017 9:46 AM > To: Alexandre Belloni; Aleksandar Markovic > Cc: linux-mips@linux-mips.org; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham > Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver > > Hi Alexandre, > > we have this sorted & plan to submit version 4 of this series next week. > > Thank you. > > Kind regards, > Miodrag > ________________________________________ > From: Alexandre Belloni [alexandre.belloni@free-electrons.com] > Sent: Thursday, August 10, 2017 10:34 PM > To: Aleksandar Markovic > Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham > Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver > > Hi, > > On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote: > > From: Miodrag Dinic > > > > Add device driver for a virtual Goldfish RTC clock. > > > > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are > > set. The compatible string used by OS for binding the driver is > > defined as "google,goldfish-rtc". > > > > Signed-off-by: Miodrag Dinic > > Signed-off-by: Goran Ferenc > > Signed-off-by: Aleksandar Markovic > > --- > > MAINTAINERS | 1 + > > drivers/rtc/Kconfig | 8 ++ > > drivers/rtc/Makefile | 1 + > > drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 243 insertions(+) > > create mode 100644 drivers/rtc/rtc-goldfish.c > > > > Do you mind fixing the remaining checkpatch --strict issues, the two > kbuild errors and the warning reported by Julia? > > Thanks! > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com